Review main Merged

81698[BUGFIX] Fix possible regression in cObjGet()

Benjamin Franzke CR +2 V +2 Easy +4 −1 updated 11/07/23, 06:30

Commit message

With #99503 `cObjGet()` was implemented as a wrapper around
the strictly typed cObjGetSeparated method, effectively
enforcing the first argument to be an array, while
previously non array values were returned as an empty string.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Rafael Kähm +1
    • Jonas Eberle +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Rafael Kähm +1
    • Jonas Eberle +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Benjamin Franzke uploaded patch set 1 11/06/23, 18:22

  2. core-ci voted on patch set 1 V +1 11/06/23, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48668

  3. Jonas Eberle commented on patch set 1 CR -1 11/06/23, 18:52

    Should be #102328
  4. Benjamin Franzke updated the commit message in patch set 2 CR -1 V +1 11/06/23, 19:00

  5. Benjamin Franzke commented on patch set 2 11/06/23, 19:01

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 11/06/23, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48669

  7. Jonas Eberle voted on patch set 2 V +1 CR +1 11/06/23, 19:19

  8. Benni Mack voted on patch set 2 V +1 CR +1 11/06/23, 20:25

  9. Rafael Kähm commented on patch set 2 V +1 CR +1 11/06/23, 22:37

    Thanks for quick reaction.
  10. Benjamin Franzke voted on patch set 2 V +2 CR +2 11/07/23, 06:30

  11. Benjamin Franzke merged patch set 3 11/07/23, 06:30