81702[BUGFIX] Fix PHP error in FormEditor property preparation
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1622
-
TYPO3com uploaded patch set 1 11/07/23, 13:18
-
core-ci voted on patch set 1 V +1 11/07/23, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48689
-
Benni Mack updated the commit message in patch set 2
V +111/07/23, 14:11 -
Oliver Klee commented on patch set 1 11/07/23, 14:11
-
core-ci voted on patch set 2 V +1 11/07/23, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48690
-
Benjamin Franzke uploaded patch set 3
V +111/10/23, 06:34 -
Benjamin Franzke commented on patch set 3 11/10/23, 06:34
FormEditorController.php:574ReplyThey are, as multiValueProperties is a list of strings. I've added respective annotations. -
Benjamin Franzke voted on patch set 3 V +1 CR +1 11/10/23, 06:34
-
Benjamin Franzke commented on patch set 3 V 0 CR -1 11/10/23, 06:39
sorry, missed something. on it. -
Benjamin Franzke uploaded patch set 4
CR -111/10/23, 06:44 -
Benjamin Franzke commented on patch set 4 11/10/23, 06:44
Reply
Done.FormEditorController.php:574ReplyA string-based map to a list of strings to be correct. -
Benjamin Franzke voted on patch set 4 V +1 CR +1 11/10/23, 06:44
-
core-ci voted on patch set 3 V -1 11/10/23, 06:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48781
-
core-ci voted on patch set 4 V +1 11/10/23, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48782
-
Benjamin Franzke commented on patch set 4 11/10/23, 08:19
BTW, I just noticed we got more problems with `type` as element identifier, since the default value of the rendered element is taken from `FormRuntime->getType()` which means it is always `'Form'` 😕 but that's a broader problem (design issue of EXT:form) which will need to be fixed separately. -
Oliver Klee voted on patch set 4 CR +1 11/10/23, 08:29
-
Stefan Bürk updated the commit message in patch set 5
CR +1V +111/19/23, 21:31 -
Stefan Bürk voted on patch set 5 V +1 CR +1 11/19/23, 21:31
-
core-ci voted on patch set 5 V +1 11/19/23, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49107
-
Oliver Klee voted on patch set 5 CR +1 11/19/23, 21:55
-
Benjamin Franzke voted on patch set 5 V +2 CR +2 11/19/23, 22:42
-
Benjamin Franzke merged patch set 6 11/20/23, 22:01
FormEditorController.php:574