Review main Abandoned

81703[BUGFIX] Prevent resetting ValuePicker select state for "replace" mode

Garvin Hicking CR 0 V 0 Easy +10 −2 updated 11/15/23, 12:47

Commit message

A "valuePicker" TCA configuration allows to either prepend, append or
replace a preset for an input field.

While "prepend" and "append" allow to continuously pick and choose
elements to be inserted, the "replace" mode is single-use and always
resets to a single chosen value.

For that "replace" case it would help not resetting the selected
dropdown element, so that both a label and value can be put into relation.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 46

  1. Garvin Hicking uploaded patch set 1 11/07/23, 14:50

  2. core-ci voted on patch set 1 V +1 11/07/23, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48691

  3. Oliver Klee updated the commit message in patch set 2 V +1 11/07/23, 16:05

  4. core-ci voted on patch set 2 V +1 11/07/23, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48694

  5. Oli Bartsch commented on patch set 2 V -1 11/08/23, 13:03

    Unresolved

    -1, since this currently does not completely resolve the reported problem. Waiting for patchset from reporter.

    Unresolved

    Since tis is no priority bugfix, I suggest to skip the 11.5 backport.
  6. Garvin Hicking abandoned the change 11/15/23, 12:47