81706[BUGFIX] Prevent possible PHP crash with empty systemLocale (follow-up)
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 2
Review log 2023
-
Garvin Hicking uploaded patch set 1 11/08/23, 07:36
-
Garvin Hicking commented on patch set 1 11/08/23, 07:36
Added what I wrote yesterday as a follow-up patch, hth. -
Xavier Perseguers voted on patch set 1 V +1 CR +1 11/08/23, 07:37
-
Xavier Perseguers commented on patch set 1 11/08/23, 07:38
Didn't face this problem while debugging yesterday but the follow-up is logical and for sure is an additional useful safeguard. -
core-ci voted on patch set 1 V +1 11/08/23, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48702
-
Oliver Klee voted on patch set 1 CR +1 11/08/23, 12:42
-
Oli Bartsch commented on patch set 1 11/08/23, 12:59
FileContentParser.php:737I think using if ($GLOBALS['TYPO3_CONF_VARS']['SYS']['systemLocale'] ?? false) would also work, allowing to be more explicit by preventing usage of the magic "empty()" method. -
Garvin Hicking commented on patch set 1 11/08/23, 14:51
FileContentParser.php:737ReplySince this is just a follow-up patch, would you want this to apply also to the parrent patch (that's been merged into v12+main already)? I can expand this patch to do that of course. -
Oli Bartsch commented on patch set 1 11/08/23, 17:32
FileContentParser.php:737ReplyGood point, let's adjust this place as well. -
Garvin Hicking uploaded patch set 2
CR +1V +111/08/23, 19:52Prevent using empty magic method -
Garvin Hicking commented on patch set 2 11/08/23, 19:53
FileContentParser.php:737ReplyRefactored the two methods. -
core-ci voted on patch set 2 V +1 11/08/23, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48731
-
Garvin Hicking commented on patch set 2 11/09/23, 12:01
Reply
Done -
Oliver Klee voted on patch set 2 CR +1 11/09/23, 12:13
-
Stefan Bürk commented on patch set 2 CR -1 11/19/23, 21:36
This uses the same forge issue number for the resolve line as https://review.typo3.org/c/Packages/TYPO3.CMS/+/81704. This needs a new issue on forge and used as `Resolve`. The issue number of the related change (#102343) needs to be added as `related` line - and the new issue should be linked to the #102343 issue. -
Garvin Hicking uploaded patch set 3
CR +1V +111/20/23, 08:30Refer to fresh issue -
Garvin Hicking commented on patch set 3 11/20/23, 08:30
Reply
Done -
core-ci voted on patch set 3 V +1 11/20/23, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49119
-
Oliver Klee voted on patch set 3 CR +1 11/20/23, 08:39
-
Andreas Kienast voted on patch set 3 CR +1 11/20/23, 10:04
-
Christian Kuhn voted on patch set 3 V +1 CR +1 11/20/23, 14:56
-
Oli Bartsch voted on patch set 3 V +2 CR +2 11/20/23, 15:00
-
Oli Bartsch merged patch set 4 11/20/23, 15:00