81712[FEATURE] Add support for AVIF files in GIFBuilder
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Resources/Private/tsref.xml3+5 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+3 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102177-WebPSupportForImagesGeneratedByGIFBUILDER.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-102353-AVIFSupportForImagesGeneratedByGIFBUILDER.rstnew+63 −0
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php19+30 −4
- typo3/sysext/install/Classes/Controller/EnvironmentController.php4+42 −0
- typo3/sysext/install/Resources/Private/Templates/Environment/ImageProcessing.html+3 −0
- typo3/sysext/install/Resources/Public/Images/TestInput/Test.avifnewbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-box.avifnewbinary
Review log 5266
Show 3141 earlier messages
-
Benni Mack uploaded patch set 1 11/08/23, 22:08
-
core-ci voted on patch set 1 V -1 11/08/23, 22:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48732
-
Benni Mack uploaded patch set 2
V -111/09/23, 09:25 -
core-ci voted on patch set 2 V +1 11/09/23, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48743
-
Benni Mack uploaded patch set 3
V +111/09/23, 09:57 -
core-ci voted on patch set 3 V +1 11/09/23, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48744
-
Oliver Klee commented on patch set 3 11/09/23, 10:17
Looks very good! I've commented on two smaller things.GifBuilder.php:493Why is the lower value for quality here 10 while it is 0 in the property? (My best guess is that is should be 0 here, too.)GifBuilder.php:2607Should we provide the allowed ranges here? ```php * @param int<10, 100> $quality The image quality (for JPEG, WebP and AVIF files) * @param int<0, 10>|null $speed The image speed (for AVIFs), null to use the default ``` -
Andreas Kienast commented on patch set 3 11/10/23, 08:03
GifBuilder.php:187Should we allow `-1`, which falls back to gdlib's default quality of 30? -
Benni Mack commented on patch set 3 11/10/23, 15:28
GifBuilder.php:187ReplyI would not set this to -1, as this is a GDlib specific thing, and I'd like to keep the options technology-free as much as possible.GifBuilder.php:493ReplyDoneGifBuilder.php:2607ReplyDone -
Benni Mack uploaded patch set 4
V +111/10/23, 15:28 -
Oliver Klee voted on patch set 4 CR +1 11/10/23, 15:37
-
core-ci voted on patch set 4 V -1 11/10/23, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48792
-
Benni Mack uploaded patch set 5
CR +1V -111/10/23, 15:44 -
core-ci voted on patch set 5 V +1 11/10/23, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48793
-
Benni Mack commented on patch set 5 11/10/23, 16:10
GifBuilder.php:2607ReplyI reverted this change for the time being as phpstan failed -
Oliver Klee voted on patch set 5 CR +1 11/10/23, 16:43
-
Oli Bartsch commented on patch set 5 V -1 11/15/23, 15:13
Feature-102353-AVIFSupportForImagesGeneratedByGIFBUILDER.rst:47Should this also be added to tsref.xml?GifBuilder.php:493Shouldn't this default to 0 like for jpg and webp?GifBuilder.php:2632This currently fails for me with: PHP Warning: imageavif(): avif error - Could not encode image: No codec available in /var/www/html/typo3/sysext/frontend/Classes/Imaging/GifBuilder.php line 2632 -
Benni Mack commented on patch set 5 11/16/23, 08:48
GifBuilder.php:2632ReplyInteresting. Seems like a "local problem" https://github.com/ddev/ddev/issues/4292 https://bugs.php.net/bug.php?id=81217 -
Benni Mack commented on patch set 5 06/13/24, 15:57
GifBuilder.php:2632ReplyOnly works in debian v12+ versions and also fixed in latest ddev versions. Can be documented in the RST. However, I can't write a test for this, as it works for me. How should we proceed @bo@cedev.de ? -
Benni Mack uploaded patch set 6
CR +1V +106/21/24, 10:16 -
core-ci voted on patch set 6 V +1 06/21/24, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59989
-
Simon Schaufelberger uploaded patch set 7
V +109/10/24, 20:01 -
core-ci voted on patch set 7 V +1 09/10/24, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65336
-
Oliver Klee wrote 09/11/24, 10:53
Removed reviewer Oliver Klee. -
Andreas Kienast commented on patch set 7 09/11/24, 11:32
GifBuilder.php:187Avif allows `-1` as argument for `quality`, falling back to the default value (currently 30). IMO we should allow this, what do you think?GifBuilder.php:482Avif allows `-1` as argument for speed, falling back to the default value (currently 6). IMO we should allow this, what do you think? -
Andreas Kienast uploaded patch set 8
V +109/12/24, 08:53 -
core-ci voted on patch set 8 V +1 09/12/24, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65546
-
Oliver Hader voted on patch set 8 CR +1 09/12/24, 10:20
-
Oliver Hader uploaded patch set 9
CR +1V +109/12/24, 10:40 -
core-ci voted on patch set 9 V +1 09/12/24, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65555
-
Guido Schmechel voted on patch set 9 V +1 09/14/24, 05:55
-
Guido Schmechel voted on patch set 9 CR +1 09/15/24, 11:00
-
Andreas Kienast voted on patch set 9 CR +1 V +1 09/16/24, 09:00
-
Markus Klein commented on patch set 9 CR +1 09/16/24, 10:24
GifBuilder.php:2632ReplyAdd a note to the rst about this potential issue, but nothing more. -
Andreas Kienast uploaded patch set 10
CR +1V +109/16/24, 10:50 -
Andreas Kienast commented on patch set 10 09/16/24, 10:51
GifBuilder.php:2632ReplyI've added a note. Please check whether it's fine. -
core-ci voted on patch set 10 V +1 09/16/24, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65879
-
Markus Klein commented on patch set 10 CR +1 09/16/24, 11:44
Perfect, thanks!GifBuilder.php:2632ReplyAcknowledged -
Andreas Kienast voted on patch set 10 CR +1 V +1 09/16/24, 13:01
-
Simon Schaufelberger commented on patch set 10 CR +1 V +1 09/16/24, 14:12
GifBuilder.php:187ReplyDone -
Simon Schaufelberger commented on patch set 10 09/16/24, 14:12
GifBuilder.php:482ReplyDoneGifBuilder.php:493ReplyDone
-
Markus Klein commented on patch set 10 V -1 09/16/24, 14:28
install tool image testing fails if avif support is not present. PHP Warning: file_get_contents(/var/www/html/typo3temp/assets/images/installTool-gdBox66e8407cdfe07941584967.avif): Failed to open stream: No such file or directory in /var/www/html/typo3/sysext/install/Classes/Controller/EnvironmentController.php line 1158 -
Markus Klein commented on patch set 10 09/16/24, 14:33
EnvironmentController.php:823If avif support is not available in PHP this returns false -
Markus Klein voted on patch set 10 CR -1 09/16/24, 14:33
-
Simon Schaufelberger commented on patch set 10 CR 0 V 0 09/16/24, 15:11
Reply
would you like to fix it so it could make it for tomorrow hopefully? -
Markus Klein commented on patch set 10 09/16/24, 19:17
Reply
Will try to give my best to help here! -
Markus Klein uploaded patch set 11
CR +1V +109/16/24, 20:30 -
Markus Klein commented on patch set 11 09/16/24, 20:30
EnvironmentController.php:823ReplyDone -
Markus Klein uploaded patch set 12 09/16/24, 20:38
-
Markus Klein commented on patch set 11 09/16/24, 20:38
Reply
DoneFeature-102353-AVIFSupportForImagesGeneratedByGIFBUILDER.rst:47ReplyDone -
Stefan Bürk uploaded patch set 13 09/16/24, 20:40
-
Garvin Hicking commented on patch set 14 09/16/24, 20:41
Published edit on patch set 13. -
Garvin Hicking commented on patch set 14 09/16/24, 20:43
EnvironmentController.php:834The other tests here use a custom "get" method for the error message. maybe for consistency do that here too? Sadly only on mobile so I can't easily do that myself. -
Stefan Bürk commented on patch set 14 CR -1 09/16/24, 20:45
on it now -
core-ci voted on patch set 11 V +1 09/16/24, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65924
-
Stefan Bürk uploaded patch set 15
CR -109/16/24, 20:53 -
core-ci voted on patch set 12 V -1 09/16/24, 20:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65925
-
Stefan Bürk commented on patch set 15 09/16/24, 20:56
EnvironmentController.php:834Replydone -
core-ci voted on patch set 15 V +1 09/16/24, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65929
-
Garvin Hicking voted on patch set 15 CR +1 V +1 09/16/24, 21:11
-
core-ci voted on patch set 12 V +1 09/16/24, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65925
-
Stefan Bürk voted on patch set 15 CR +2 V +2 09/16/24, 21:30
-
Stefan Bürk merged patch set 16 09/16/24, 21:30
-
Andreas Kienast commented on patch set 16 09/17/24, 06:19
tsref.xml:1380-1? -
Markus Klein commented on patch set 16 09/17/24, 06:45
tsref.xml:1380Replythen we need "int (-1-10)" here? -
Andreas Kienast commented on patch set 16 09/17/24, 07:14
tsref.xml:1380Reply UnresolvedI think so, yes.