Review main Merged

81713[BUGFIX] Remove "max" property for new TCA type "email"

Simon Schaufelberger CR +2 V +2 Easy +17 −2 updated 11/17/23, 08:52

Commit message

Remove outdated "max" property.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2530

Show 45 earlier messages
  1. Simon Schaufelberger uploaded patch set 1 11/09/23, 00:49

  2. core-ci voted on patch set 1 V +1 11/09/23, 00:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48733

  3. Chris Müller commented on patch set 1 11/09/23, 09:47

    Feature-97013-NewTCATypeEmail.rst:71

    "max" is not listed in the column configuration above. So either "max" is set automatically to 255 or it is missing in the list.
  4. Oli Bartsch commented on patch set 1 V -1 11/09/23, 10:45

    Feature-97013-NewTCATypeEmail.rst:71 Reply

    Correct, "max" is no longer supported for this TCA type.
  5. Simon Schaufelberger commented on patch set 1 11/09/23, 11:48

    Feature-97013-NewTCATypeEmail.rst:71 Reply

    Does that imply that the actual migration is wrong?
  1. Simon Schaufelberger commented on patch set 1 11/09/23, 11:50

    Feature-97013-NewTCATypeEmail.rst:71 Reply

    There are definitely fields that will be kept like size and nullable.
  2. Oli Bartsch commented on patch set 1 11/10/23, 07:52

    Feature-97013-NewTCATypeEmail.rst:71 Reply

    The migration is correct. The max option is no longer set, because it’s automatically applied in the element. that’s what the example outlines.
  3. Simon Schaufelberger commented on patch set 1 11/10/23, 08:38

    Feature-97013-NewTCATypeEmail.rst:71 Reply

  4. Oli Bartsch commented on patch set 1 11/10/23, 10:23

    Feature-97013-NewTCATypeEmail.rst:71 Reply

    Yes, the Migration does not remove every outdated option. However, in this case we could extend it accordingly.
  5. Simon Schaufelberger uploaded patch set 2 V +1 11/11/23, 23:18

  6. Simon Schaufelberger commented on patch set 2 11/11/23, 23:20

    Feature-97013-NewTCATypeEmail.rst:71 Reply

    I came up with an approach. Please give me feedback if this is a good one or if there are other and better ways to remove outdated config values.
  7. core-ci voted on patch set 2 V +1 11/11/23, 23:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48828

  8. Oli Bartsch commented on patch set 2 11/13/23, 08:28

    Feature-97013-NewTCATypeEmail.rst:71 Reply

    I really like the idea of removing all outdated information. Let's however make a pre patch, introducing this functionality, maybe in a dedicated service, covering all possible config options and having the logic of removing all not relevant options from an array there. This can then be covered with dedicated tests. I also would like to have the "allowed" options at a central place and not in the migration. Maybe we could place them in the FormEngine Element class. In a next step we could add the service to all the relevant migrations. What do you think?
  9. Christian Kuhn commented on patch set 2 11/13/23, 13:16

    TcaMigration.php:685

    I'm not sure if we should blindly remove any config options the core thinks is 'not valid': Nobody prevents devs from inventing and using new config flags, for instance when own renderType's are used. Removing those may break things. What do you think?
  10. Christian Kuhn commented on patch set 2 11/13/23, 13:18

    TcaMigration.php:685 Reply

    would it be enough to clean up only the 'max' key?
  11. Oli Bartsch commented on patch set 2 11/14/23, 09:47

    TcaMigration.php:685 Reply

    Good point. Did not thought about custom config options. Yes, in this case we might just remove the max key for now.
  12. Simon Schaufelberger uploaded patch set 3 V +1 11/16/23, 11:04

  13. Simon Schaufelberger commented on patch set 3 11/16/23, 11:09

    TcaMigration.php:685 Reply

    Done

    Feature-97013-NewTCATypeEmail.rst:71 Reply

    Done
  14. core-ci voted on patch set 3 V +1 11/16/23, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49014

  15. Simon Schaufelberger commented on patch set 3 CR -1 11/16/23, 11:15

    The max property should be also removed for other TCA types, as not all of the new ones make use of it.
  16. Simon Schaufelberger commented on patch set 3 CR 0 11/16/23, 11:26

    Reply

    - password [DONE] - email [DONE] - number [DONE] - colorpicker [DONE] - datetime [DONE] - link [DONE] ok so only email was forgotten.
  17. Simon Schaufelberger updated the commit message in patch set 4 V +1 11/16/23, 11:28

  18. Simon Schaufelberger uploaded patch set 5 11/16/23, 11:29

  19. core-ci voted on patch set 5 V +1 11/16/23, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49016

  20. core-ci voted on patch set 4 V +1 11/16/23, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49015

  21. Oli Bartsch voted on patch set 5 V +1 CR +1 11/17/23, 08:16

  22. Nikita Hovratov voted on patch set 5 V +1 CR +1 11/17/23, 08:30

  23. Nikita Hovratov voted on patch set 5 V +2 CR +2 11/17/23, 08:33

  24. Oliver Klee voted on patch set 5 V +1 CR +1 11/17/23, 08:41

  25. Nikita Hovratov merged patch set 6 11/17/23, 08:52