81713[BUGFIX] Remove "max" property for new TCA type "email"
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Oli Bartsch +1
- Oliver Klee +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Oli Bartsch +1
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2530
Show 45 earlier messages
-
Simon Schaufelberger uploaded patch set 1 11/09/23, 00:49
-
core-ci voted on patch set 1 V +1 11/09/23, 00:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48733
-
Chris Müller commented on patch set 1 11/09/23, 09:47
-
Oli Bartsch commented on patch set 1 V -1 11/09/23, 10:45
Feature-97013-NewTCATypeEmail.rst:71ReplyCorrect, "max" is no longer supported for this TCA type. -
Simon Schaufelberger commented on patch set 1 11/09/23, 11:48
Feature-97013-NewTCATypeEmail.rst:71ReplyDoes that imply that the actual migration is wrong?
-
Simon Schaufelberger commented on patch set 1 11/09/23, 11:50
Feature-97013-NewTCATypeEmail.rst:71ReplyThere are definitely fields that will be kept like size and nullable. -
Oli Bartsch commented on patch set 1 11/10/23, 07:52
Feature-97013-NewTCATypeEmail.rst:71ReplyThe migration is correct. The max option is no longer set, because it’s automatically applied in the element. that’s what the example outlines. -
Simon Schaufelberger commented on patch set 1 11/10/23, 08:38
Feature-97013-NewTCATypeEmail.rst:71ReplyThis migration leaves the 'max' field still there: https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Classes/Configuration/Tca/TcaMigration.php#L623 -
Oli Bartsch commented on patch set 1 11/10/23, 10:23
Feature-97013-NewTCATypeEmail.rst:71ReplyYes, the Migration does not remove every outdated option. However, in this case we could extend it accordingly. -
Simon Schaufelberger uploaded patch set 2
V +111/11/23, 23:18 -
Simon Schaufelberger commented on patch set 2 11/11/23, 23:20
Feature-97013-NewTCATypeEmail.rst:71ReplyI came up with an approach. Please give me feedback if this is a good one or if there are other and better ways to remove outdated config values. -
core-ci voted on patch set 2 V +1 11/11/23, 23:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48828
-
Oli Bartsch commented on patch set 2 11/13/23, 08:28
Feature-97013-NewTCATypeEmail.rst:71ReplyI really like the idea of removing all outdated information. Let's however make a pre patch, introducing this functionality, maybe in a dedicated service, covering all possible config options and having the logic of removing all not relevant options from an array there. This can then be covered with dedicated tests. I also would like to have the "allowed" options at a central place and not in the migration. Maybe we could place them in the FormEngine Element class. In a next step we could add the service to all the relevant migrations. What do you think? -
Christian Kuhn commented on patch set 2 11/13/23, 13:16
TcaMigration.php:685I'm not sure if we should blindly remove any config options the core thinks is 'not valid': Nobody prevents devs from inventing and using new config flags, for instance when own renderType's are used. Removing those may break things. What do you think? -
Christian Kuhn commented on patch set 2 11/13/23, 13:18
TcaMigration.php:685Replywould it be enough to clean up only the 'max' key? -
Oli Bartsch commented on patch set 2 11/14/23, 09:47
TcaMigration.php:685ReplyGood point. Did not thought about custom config options. Yes, in this case we might just remove the max key for now. -
Simon Schaufelberger uploaded patch set 3
V +111/16/23, 11:04 -
Simon Schaufelberger commented on patch set 3 11/16/23, 11:09
TcaMigration.php:685ReplyDoneFeature-97013-NewTCATypeEmail.rst:71ReplyDone -
core-ci voted on patch set 3 V +1 11/16/23, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49014
-
Simon Schaufelberger commented on patch set 3 CR -1 11/16/23, 11:15
The max property should be also removed for other TCA types, as not all of the new ones make use of it. -
Simon Schaufelberger commented on patch set 3 CR 0 11/16/23, 11:26
Reply
- password [DONE] - email [DONE] - number [DONE] - colorpicker [DONE] - datetime [DONE] - link [DONE] ok so only email was forgotten. -
Simon Schaufelberger updated the commit message in patch set 4
V +111/16/23, 11:28 -
Simon Schaufelberger uploaded patch set 5 11/16/23, 11:29
-
core-ci voted on patch set 5 V +1 11/16/23, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49016
-
core-ci voted on patch set 4 V +1 11/16/23, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49015
-
Oli Bartsch voted on patch set 5 V +1 CR +1 11/17/23, 08:16
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 11/17/23, 08:30
-
Nikita Hovratov voted on patch set 5 V +2 CR +2 11/17/23, 08:33
-
Oliver Klee voted on patch set 5 V +1 CR +1 11/17/23, 08:41
-
Nikita Hovratov merged patch set 6 11/17/23, 08:52
Feature-97013-NewTCATypeEmail.rst:71