Review main Merged

81716[BUGFIX] Create symlinks for public assets with specific vendor names

Garvin Hicking CR +2 V +2 Easy +2 −1 updated 11/20/23, 16:15

Commit message

When `composer install|dumpautoload` is performed, the
PackageArtifactBuilder inspects the list of all extensions, and
then creates symlinks to `Resources/Public` of each extension
into the `_assets` subdirectory.

This step could fail, when a vendor name ended on "ext".
A package in `vendor/superagency-next/myextension/Resources/Public`
would not have gotten symlinked, because "ext/myextension"
matches in this combination.

The fix is to check the directory for the actual pattern
of non-composer legacy installations (which is available as a constant).

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Garvin Hicking uploaded patch set 1 11/09/23, 13:01

  2. core-ci voted on patch set 1 V +1 11/09/23, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48752

  3. Oliver Klee voted on patch set 1 CR +1 11/09/23, 13:19

  4. Simon Schaufelberger voted on patch set 1 CR +1 11/10/23, 07:48

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 11/20/23, 15:57

  6. Stefan Bürk voted on patch set 1 V +2 CR +2 11/20/23, 15:58

  7. Stefan Bürk merged patch set 2 11/20/23, 16:15