81717[DOCS] Link to width/height docs permalink in f:image ViewHelper
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Lina Wolf +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Lina Wolf +1
Issues 1
Files 1
Review log 1113
-
TYPO3com uploaded patch set 1 11/09/23, 13:25
-
Garvin Hicking commented on patch set 1 11/09/23, 13:29
While it would be nice to have links directly at this place, maintaining those across versions of TYPO3 (and with possible changes of docs.typo3.org) is a bit harder to achieve, and isn't done on most other places. Maybe a more generic approach could be added here, like "in the TypoScript References of the TYPO3 Documentation, in the section about 'ImgResource'."? -
core-ci voted on patch set 1 V +1 11/09/23, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48753
-
Chris Müller commented on patch set 1 V -1 11/09/23, 14:59
I am with Garvin: - This always links to the dev version and not to the LTS version. - It is hard to recognize when the link changes. -
Chris Müller commented on patch set 1 11/11/23, 15:04
will provide a better solution -
Chris Müller commented on patch set 1 11/11/23, 17:43
Hmm :ref: syntax is working, but I assume only in the same documentation as there is no Settings.cfg available for defining intersphinx. So intersphinx/cross-referencing may not be possible. Don't know the magic yet of the action which renders the view helper docs and therefore can't test it. -
Garvin Hicking commented on patch set 2
V +112/18/24, 12:37Published edit on patch set 1. -
Garvin Hicking updated the commit message in patch set 3 12/18/24, 12:39
-
Garvin Hicking commented on patch set 3 CR +1 V +1 12/18/24, 12:41
Reply
DoneReply
DoneReply
I think we can be pragmatic here and link to the recent version. Inserting a link that can be parametrized would make the link not be resolvable in IDEs.Reply
Done -
Lina Wolf voted on patch set 3 CR +1 V +1 12/18/24, 12:42
-
Oli Bartsch voted on patch set 3 CR +1 V +1 12/18/24, 12:43
-
Garvin Hicking voted on patch set 3 CR +2 V +2 12/18/24, 12:51
-
Garvin Hicking merged patch set 4 12/18/24, 12:59