Review main Merged

81723[TASK] Fix changelog for TCA slug generatorOptions

Sybille Peters CR +2 V +2 Easy +24 −14 updated 11/13/23, 14:59

Commit message

TCA fields of type 'slug' can be configured with the property
generatorOptions.

Particularly, the short form of using a simple array for
the fields instead of a nested array is a common source
of confusion and the initially introduced changelog had
incorrect examples.

The changelog is improved as follows

- Fix the examples. The examples 2 and 3 showed incorrect
  results
- Use the multidimensional array in the source snippet
- Clarify that ['nav_title', 'title'] is the same as
  [['nav_title'], ['title']], but not the same as
  [['nav_title', 'title']]

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Sybille Peters uploaded patch set 1 11/12/23, 12:45

  2. core-ci voted on patch set 1 V +1 11/12/23, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48832

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 11/13/23, 08:05

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 11/13/23, 14:59

  5. Christian Kuhn merged patch set 2 11/13/23, 14:59