Review main Merged

81724[BUGFIX] Verify Popover instances before usage

Christian Kuhn CR +2 V +2 Easy +25 −15 updated 11/13/23, 14:17

Commit message

In AC tests it appears that popover instances are not available, either
because the DOM isn't ready yet, or the element got removed meanwhile,
leading to AC test failures.

As a safety net, popover instances are now checked for not being `null`,
and a warning is logged in the console.

Also, the `@typo3/backend/context-help` module now waits for a ready DOM
and only takes elements into consideration that existed on
initialization time.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1017

  1. Christian Kuhn uploaded patch set 1 11/13/23, 11:55

  2. Andreas Kienast commented on patch set 1 11/13/23, 12:16

    popover.ts:107

    To be ultra safe, I'd do that check every time `.getInstance()` is used (`show`, `destroy`, etc.).
  3. core-ci voted on patch set 1 V +1 11/13/23, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48843

  4. core-ci commented on patch set 1 11/13/23, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48844

  5. Andreas Kienast uploaded patch set 2 V +1 11/13/23, 12:40

  6. Andreas Kienast commented on patch set 2 11/13/23, 12:40

    popover.ts:107 Reply

    Done
  7. Andreas Kienast uploaded patch set 3 11/13/23, 12:41

  8. core-ci voted on patch set 2 V +1 11/13/23, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48845

  9. core-ci voted on patch set 3 V +1 11/13/23, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48846

  10. Andreas Kienast uploaded patch set 4 V +1 11/13/23, 13:19

  11. core-ci voted on patch set 4 V +1 11/13/23, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48847

  12. Benjamin Franzke voted on patch set 4 V +1 CR +1 11/13/23, 13:32

  13. core-ci voted on patch set 4 V -1 11/13/23, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48848

  14. Andreas Kienast voted on patch set 4 V +1 CR +1 11/13/23, 14:06

  15. core-ci voted on patch set 4 V +1 11/13/23, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48848

  16. Christian Kuhn voted on patch set 4 V +2 CR +2 11/13/23, 14:17

  17. Christian Kuhn merged patch set 5 11/13/23, 14:17