Review 12.4 Merged

81725[BUGFIX] Verify Popover instances before usage

Christian Kuhn CR +2 V +2 Easy +25 −15 updated 11/13/23, 14:17

Commit message

In AC tests it appears that popover instances are not available, either
because the DOM isn't ready yet, or the element got removed meanwhile,
leading to AC test failures.

As a safety net, popover instances are now checked for not being `null`,
and a warning is logged in the console.

Also, the `@typo3/backend/context-help` module now waits for a ready DOM
and only takes elements into consideration that existed on
initialization time.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 35

  1. Christian Kuhn uploaded patch set 1 11/13/23, 13:33

  2. core-ci voted on patch set 1 V +1 11/13/23, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48849

  3. core-ci commented on patch set 1 11/13/23, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48850

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 11/13/23, 14:17

  5. Christian Kuhn merged patch set 2 11/13/23, 14:17