Review main Merged

81729[SECURITY] Limit user session to cookie domain

Benjamin Franzke CR +2 V +2 Hard +210 −63 updated 11/14/23, 09:29

Commit message

Given that there are two sites `site-a.com` and `site-b.com` in
the same TYPO3 installation, it was possible to reuse a session
cookie that was generated for `site-a.com` in `site-b.com`.

Since there are scenarios, where this is the expected behavior
– when sharing sessions across sub domains, so that an explicit
cookieDomain needs to be configured – user sessions signatures
are now salted with the desired cookie domain, so that a cookie
can only be used on the domain that the cookie was created for.

Testing framework will need to be adapted in a subsequent patch,
but for the time being – and for compatiblity with possible 3rd
party authenticators – legacy tokens will be accepted, but not
created by TYPO3 core.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 9

Review log 89

  1. Benjamin Franzke uploaded patch set 1 11/13/23, 19:27

  2. Benjamin Franzke wrote 11/13/23, 19:27

    Set private
  3. Benjamin Franzke abandoned the change 11/13/23, 19:31

    wrong push
  4. Benjamin Franzke restored the change 11/14/23, 08:43

  5. Benjamin Franzke wrote 11/14/23, 08:51

    Unset private
  6. Oliver Hader uploaded patch set 2 11/14/23, 08:58

  7. Oliver Hader commented on patch set 2 V +2 CR +2 11/14/23, 08:58

    Auto-approved
  8. Oliver Hader merged patch set 3 11/14/23, 08:58

  9. core-ci voted on patch set 2 V +1 11/14/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48891