Review 11.5 Merged

81731[SECURITY] Limit user session to cookie domain

Oliver Hader CR +2 V +2 Normal +153 −14 updated 11/14/23, 09:07

Commit message

Given that there are two sites `site-a.com` and `site-b.com` in
the same TYPO3 installation, it was possible to reuse a session
cookie that was generated for `site-a.com` in `site-b.com`.

Since there are scenarios, where this is the expected behavior
– when sharing sessions across sub domains, so that an explicit
cookieDomain needs to be configured – user sessions IDs are now
signed with a combination of encryption key and desired cookie
domain, so that a cookie can only be used on the domain that the
cookie was created for.

For compatiblity with possible 3rd party authenticators, legacy
tokens will be accepted (but not created by TYPO3 core itself).

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 6

Review log 34

  1. Oliver Hader uploaded patch set 1 11/14/23, 08:57

  2. Oliver Hader commented on patch set 1 V +2 CR +2 11/14/23, 08:57

    Auto-approved
  3. Oliver Hader merged patch set 2 11/14/23, 08:57

  4. core-ci voted on patch set 1 V +1 11/14/23, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48885