81742[BUGFIX] Keep ValuePicker in sync with field value for replace mode
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Oli Bartsch +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1519
-
Sascha Egerer uploaded patch set 1 11/14/23, 10:11
-
Sascha Egerer commented on patch set 1 11/14/23, 10:11
I need this change in a TYPO3 11.5 installation but also fine for me if it'll not be backported. -
core-ci voted on patch set 1 V +1 11/14/23, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48899
-
Oli Bartsch uploaded patch set 2
V +111/15/23, 11:07 -
Oli Bartsch commented on patch set 2 V +1 CR +1 11/15/23, 11:08
GREAT PATCH! -
core-ci voted on patch set 2 V +1 11/15/23, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48948
-
Nikita Hovratov updated the commit message in patch set 3
CR +1V +111/15/23, 12:16 -
Nikita Hovratov voted on patch set 3 V +1 CR +1 11/15/23, 12:21
-
core-ci voted on patch set 3 V +1 11/15/23, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48954
-
Oli Bartsch updated the commit message in patch set 4
CR +1V +111/15/23, 13:31 -
Oli Bartsch voted on patch set 4 V +1 CR +1 11/15/23, 13:31
-
core-ci voted on patch set 4 V +1 11/15/23, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48955
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 11/15/23, 13:41
-
Oli Bartsch voted on patch set 4 V +2 CR +2 11/15/23, 15:13
-
Oli Bartsch merged patch set 5 11/15/23, 15:13
-
Andreas Kienast commented on patch set 5 11/28/23, 11:10
value-picker.ts:42Post -1: this is not cleared in `disconnectedCallback()`. -
Sascha Egerer commented on patch set 5 11/28/23, 11:31
value-picker.ts:42ReplyYou're right. Should I take care of it or are you already there? -
Andreas Kienast commented on patch set 5 11/28/23, 11:57
value-picker.ts:42ReplyWe're investigating another issue here. In rare cases `selectValue()` breaks because `this.valuePicker` is null, which doesn't make much sense here, IMO. Both will get fixed altogether. -
Sascha Egerer commented on patch set 5 11/28/23, 12:44
value-picker.ts:42Reply Unresolved👍