Review main Merged

81742[BUGFIX] Keep ValuePicker in sync with field value for replace mode

Sascha Egerer CR +2 V +2 Normal +40 −12 updated 11/28/23, 12:44

Commit message

A "valuePicker" TCA configuration allows to either prepend, append or
replace a preset for an input field.

While "prepend" and "append" allow to continuously pick and choose
elements to be inserted, the "replace" mode is single-use and always
resets to a single chosen value.

For the "replace" mode it could be helpful to keep the input field
in sync with the ValuePicker especially if the value picker as a
human-readable representation of the value that is added in the
input field.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1519

  1. Sascha Egerer uploaded patch set 1 11/14/23, 10:11

  2. Sascha Egerer commented on patch set 1 11/14/23, 10:11

    I need this change in a TYPO3 11.5 installation but also fine for me if it'll not be backported.
  3. core-ci voted on patch set 1 V +1 11/14/23, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48899

  4. Oli Bartsch uploaded patch set 2 V +1 11/15/23, 11:07

  5. Oli Bartsch commented on patch set 2 V +1 CR +1 11/15/23, 11:08

    GREAT PATCH!
  6. core-ci voted on patch set 2 V +1 11/15/23, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48948

  7. Nikita Hovratov updated the commit message in patch set 3 CR +1 V +1 11/15/23, 12:16

  8. Nikita Hovratov voted on patch set 3 V +1 CR +1 11/15/23, 12:21

  9. core-ci voted on patch set 3 V +1 11/15/23, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48954

  10. Oli Bartsch updated the commit message in patch set 4 CR +1 V +1 11/15/23, 13:31

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 11/15/23, 13:31

  12. core-ci voted on patch set 4 V +1 11/15/23, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48955

  13. Nikita Hovratov voted on patch set 4 V +1 CR +1 11/15/23, 13:41

  14. Oli Bartsch voted on patch set 4 V +2 CR +2 11/15/23, 15:13

  15. Oli Bartsch merged patch set 5 11/15/23, 15:13

  16. Andreas Kienast commented on patch set 5 11/28/23, 11:10

    value-picker.ts:42

    Post -1: this is not cleared in `disconnectedCallback()`.
  17. Sascha Egerer commented on patch set 5 11/28/23, 11:31

    value-picker.ts:42 Reply

    You're right. Should I take care of it or are you already there?
  18. Andreas Kienast commented on patch set 5 11/28/23, 11:57

    value-picker.ts:42 Reply

    We're investigating another issue here. In rare cases `selectValue()` breaks because `this.valuePicker` is null, which doesn't make much sense here, IMO. Both will get fixed altogether.
  19. Sascha Egerer commented on patch set 5 11/28/23, 12:44

    value-picker.ts:42 Reply Unresolved

    👍