Review main Merged

81749[BUGFIX] Correctly re-import extension static-data

Markus Klein CR +2 V +2 Easy +11 −5 updated 11/29/23, 21:17

Commit message

The ext_tables_static+adt.sql data are now re-imported,
if its data changed, when setting up the extensions.

This happens either from within the Extension Manager,
or via the CLI  command.

Moreover, a legacy value, which was already taken care of
in `ReloadSqlDataViewHelper`, is now respected as well.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1821

  1. Markus Klein uploaded patch set 1 11/15/23, 15:23

  2. core-ci voted on patch set 1 V +1 11/15/23, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48961

  3. Thomas Hohn voted on patch set 1 CR +1 11/15/23, 17:08

  4. Simon Schaufelberger commented on patch set 1 V +1 CR +1 11/15/23, 22:34

    This whole import thing works in a way which I would not expect. Why is the event fired even though nothing is done? In my opinion the last part should also be inside the if file_exists block.
  5. Markus Klein commented on patch set 1 11/16/23, 08:58

    Reply

    I kept it that way to stay backwards compatible. The event basically says "I processed a possibly existing static.sql file for that extension"
  6. Garvin Hicking commented on patch set 1 11/21/23, 20:44

    Great work! Note sure about the v11 backport, maybe we should first see impact on v12&main instances, because maybe some extensions utilized the fact that a re-import was not done after first-time instantiation, and it could probably drop tables that people would not expect? I wonder if due to that we might actually need a BC declaration...? (Or am I misreading the implications? I know the docs explicitly state you shall not use static data to populate post-install, and always keep it dropable - but since that didn't happen, it might break "muscle memory"?)
  7. Markus Klein commented on patch set 1 11/21/23, 20:52

    Reply

    I think we could do an "important" RST. Waiting for "feedback" on v12/main is not really useful yet. There are simply too few v12 installations out there to expect a serious response.
  8. Andreas Wolf voted on patch set 1 CR +1 11/23/23, 19:05

  9. Christian Kuhn commented on patch set 1 11/26/23, 10:25

    Reply

    I'd argue this is not critical for v11 since the existing behavior exists for so many versions already. I'd rather not take the risk for v11 and will remove it from the releases line, hoping this does not raise a huge discussion.
  10. Christian Kuhn uploaded patch set 2 CR +1 V +1 11/26/23, 10:27

  11. Christian Kuhn updated the commit message in patch set 3 11/26/23, 10:28

  12. Christian Kuhn commented on patch set 3 11/26/23, 10:29

    InstallUtility.php:337

    maybe ->remove() if there is no file?
  13. core-ci voted on patch set 2 V +1 11/26/23, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49947

  14. core-ci voted on patch set 3 V +1 11/26/23, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49948

  15. Markus Klein commented on patch set 3 11/27/23, 08:05

    InstallUtility.php:337 Reply

    I thought about that. But we must remember that we tried the import once. Even if there is no file. I wouldn't touch that for b/w-compat as well.
  16. Christian Kuhn commented on patch set 3 11/27/23, 11:29

    InstallUtility.php:337 Reply

    ack.
  17. Christian Kuhn voted on patch set 3 CR +1 V +1 11/27/23, 11:30

  18. Stefan Bürk voted on patch set 3 CR +1 V +1 11/29/23, 20:46

  19. Thomas Hohn voted on patch set 3 CR +1 11/29/23, 20:53

  20. Christian Kuhn voted on patch set 3 CR +2 V +2 11/29/23, 21:17

  21. Christian Kuhn merged patch set 4 11/29/23, 21:17