Review 11.5 Merged

81756[BUGFIX] Avoid 1s client-side backend request caching

Benjamin Franzke CR +2 V +2 Easy +5 −5 updated 11/16/23, 10:12

Commit message

Backend responses must never be cached. The previously used
Cache-Control instruction "must-revalidate" implicitly enabled
caching in order to possibly reuse a response. While that
could only happen when two requests to the same URL are
invoked within one second (because the browsers
`If-Modified-Since` header and our `Last-Modified` header
match, causing the webserver to issue a 304 response),
that is certainly possible in CI setups or fast user clicks.

Use `no-store` in order to instruct browsers to not cache
and try revalidation at all.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5