Review main Merged

81757[BUGFIX] Set DOM attributes to Page module columns with defLangBinding enabled

Andreas Kienast CR +2 V +2 Easy +10 −7 updated 11/21/23, 08:44

Commit message

The Page module loads a different partial to render its columns if
`defLangBinding` is enabled, that misses some DOM attributes required
for drag&drop handling.

This patch now adds the necessary attributes (data attributes, CSS
classes).

Also, to workaround a rendering issue, the page module now reloads
itself after dropping an element into a column.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Annett Jähnichen +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Annett Jähnichen +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 67

  1. Andreas Kienast uploaded patch set 1 11/16/23, 12:36

  2. core-ci voted on patch set 1 V +1 11/16/23, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49020

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 11/16/23, 16:49

  4. Annett Jähnichen commented on patch set 1 V +1 11/20/23, 15:48

    Tested with main Branch
  5. Annett Jähnichen voted on patch set 1 CR +1 11/21/23, 08:30

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 11/21/23, 08:44

  7. Oli Bartsch merged patch set 2 11/21/23, 08:44