Review main Merged

81758[BUGFIX] Consider URL encoded values for addQueryString.exclude

Oliver Hader CR +2 V +2 Normal +30 −24 updated 12/20/23, 10:33

Commit message

TypoScript property `addQueryString.exclude` concerns the internal,
URL-decoded values. However, the parameters are purged from a query
array that is URL-encoded.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1014

  1. Oliver Hader uploaded patch set 1 11/16/23, 14:02

  2. Oliver Hader uploaded patch set 2 11/16/23, 14:02

  3. core-ci voted on patch set 1 V -1 11/16/23, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49027

  4. core-ci voted on patch set 2 V +1 11/16/23, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49028

  5. Oliver Hader rebased onto patch set 3 V +1 11/16/23, 15:03

  6. core-ci voted on patch set 3 V +1 11/16/23, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49034

  7. Benni Mack commented on patch set 3 11/17/23, 10:47

    PageLinkBuilder.php:775

    you can use urlencode(...)
  8. Simon Schaufelberger uploaded patch set 4 V +1 11/21/23, 18:51

  9. Simon Schaufelberger commented on patch set 3 11/21/23, 18:51

    PageLinkBuilder.php:775 Reply

    Done
  10. core-ci voted on patch set 4 V +1 11/21/23, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49285

  11. Simon Schaufelberger voted on patch set 4 V +1 CR +1 11/21/23, 19:00

  12. Benni Mack voted on patch set 4 CR +1 V +1 12/15/23, 22:35

  13. Oliver Hader voted on patch set 4 CR +2 V +2 12/20/23, 10:32

  14. Oliver Hader merged patch set 5 12/20/23, 10:33