Review main Abandoned

81763[BUGFIX] Respect null attributes within FileRenderer implementations

Henrik Elsner CR 0 V -1 Easy +6 −6 updated 09/04/26, 07:42

Commit message

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 4

Review log 912

  1. Henrik Elsner uploaded patch set 1 11/17/23, 11:08

  2. core-ci voted on patch set 1 V +1 11/17/23, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49057

  3. Benni Mack commented on patch set 1 11/17/23, 11:49

    also check out https://review.typo3.org/c/Packages/TYPO3.CMS/+/76103 we have too many implementations of this stuff
  4. Henrik Elsner commented on patch set 1 11/17/23, 12:36

    Reply

    Ah I see. Also thought about combining the methods in a class or something as they're the same. Should I mark my patch with a TODO and refer to your patch or take on your patch, add my case and search for further usages?
  5. Henrik Elsner commented on patch set 1 12/06/23, 10:22

    Reply

    just stumbled upon this - can i help somehow?
  6. Oliver Hader updated the commit message in patch set 2 V +1 10/18/24, 14:08

  7. Oliver Hader rebased onto patch set 3 04/11/25, 21:10

  8. core-ci voted on patch set 3 V +1 04/11/25, 21:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77582

  9. Benni Mack wrote 04/21/26, 14:59

    Removed cc Benni Mack.
  10. Benni Mack updated the commit message in patch set 4 V +1 04/22/26, 06:27

  11. core-ci voted on patch set 4 V -1 04/22/26, 06:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100704

  12. Garvin Hicking abandoned the change 09/04/26, 07:42