Review main Merged

81764[BUGFIX] Make DB raw search work reliable and consistent

Oli Bartsch CR +2 V +2 Normal +59 −29 updated 11/18/23, 00:29

Commit message

The raw search in the DB check module now
works reliable and consistent with other
search functionality in the backend.

Therefore the search now uses proper JS to:

* Submit the form on browser clear
* Monitor search term inputs
* Toggling the submit button

Additionally, the template got adjusted:

* Display of proper info for search with no results
* Display of proper info for an empty search
* Usage of aria-labeldby
* Usage of search icon in combination with
  the <button> tag for consistency
* Resolving duplicated if clauses

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 56

  1. Oli Bartsch uploaded patch set 1 11/17/23, 11:54

  2. core-ci voted on patch set 1 V +1 11/17/23, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49061

  3. Benni Mack voted on patch set 1 V +1 CR +1 11/17/23, 15:35

  4. Jochen Roth voted on patch set 1 V +1 CR +1 11/17/23, 18:23

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 11/18/23, 00:29

  6. Oli Bartsch merged patch set 2 11/18/23, 00:29