Review main Merged

81798[TASK] Make file replace file input accessible with keyboard

Willi Wehmeier CR +2 V +2 Easy +2 −2 updated 11/21/23, 08:57

Commit message

This patch makes the browse button on the file input field
for the file replace dialog in the filelist module reachable
via keyboard.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Willi Wehmeier +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Willi Wehmeier +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Willi Wehmeier uploaded patch set 1 11/20/23, 12:42

  2. Kai Ole Hartwig voted on patch set 1 V +1 CR +1 11/20/23, 12:45

  3. core-ci voted on patch set 1 V +1 11/20/23, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49129

  4. Oli Bartsch commented on patch set 1 CR -1 11/20/23, 16:18

    ReplaceFile.html:24

    This should be a button instead. This would also allow keyboard access by default without the JS changes.
  5. Oli Bartsch uploaded patch set 2 CR +1 V +1 11/20/23, 16:21

  6. Oli Bartsch commented on patch set 2 V +1 CR +1 11/20/23, 16:21

    ReplaceFile.html:24 Reply

    Done
  7. core-ci voted on patch set 2 V +1 11/20/23, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49156

  8. Garvin Hicking voted on patch set 2 V +1 CR +1 11/20/23, 22:14

  9. Willi Wehmeier commented on patch set 2 V +1 CR +1 11/21/23, 06:14

    ReplaceFile.html:24 Reply

    This is even better, thanks. :)
  10. Oli Bartsch voted on patch set 2 V +2 CR +2 11/21/23, 08:57

  11. Oli Bartsch merged patch set 3 11/21/23, 08:57