81800[TASK] Add visually hidden label to the search buttons
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Kott +2
- Jasmina Ließmann +1
- Michael Telgkamp +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Kott +2
- Jasmina Ließmann +1
- Michael Telgkamp +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/Active.html+4 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Index.html+4 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Ter.html+1 −0
- typo3/sysext/filelist/Resources/Private/Templates/File/List.html5+4 −1
- typo3/sysext/lowlevel/Resources/Private/Templates/Configuration.html+4 −1
- typo3/sysext/recycler/Resources/Private/Templates/RecyclerModule.html+4 −1
- typo3/sysext/tstemplate/Resources/Private/Partials/ActiveOptions.html+4 −1
- typo3/sysext/workspaces/Resources/Private/Partials/WorkingTable.html+4 −1
Review log 2733
Show 58 earlier messages
-
Christian Rath-Ulrich uploaded patch set 1 11/20/23, 14:54
-
core-ci voted on patch set 1 V +1 11/20/23, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49136
-
Oli Bartsch commented on patch set 1 CR -1 11/20/23, 15:27
locallang.xlf:7Similar to the title used in the DB check module ("Search all records"), I suggest to use "Search files and folders" as title.List.html:54Why do we need the hidden <span> since we already use the title attribute? -
Christian Rath-Ulrich uploaded patch set 2
CR -1V +111/20/23, 16:23 -
core-ci voted on patch set 2 V +1 11/20/23, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49158
-
Christian Rath-Ulrich rebased onto patch set 3
V +111/20/23, 19:29 -
core-ci voted on patch set 3 V +1 11/20/23, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49186
-
Christian Rath-Ulrich commented on patch set 3 11/22/23, 11:49
locallang.xlf:6Replyyes fixed thatlocallang.xlf:7Replyyes fixed thatList.html:54ReplyTitles are not read aloud by screen readers unless you have activated this as an extra plugin. Therefore, only the title is not sufficient. However, I thought it could be quite practical for visually orientated users.
-
Jasmina Ließmann commented on patch set 3 11/22/23, 13:44
We have several occurrences where the search button has no label (e.g. in the "Recycler", "List", and "Workspace" modules). There is also such a button without a label in the “Configuration”, “TypeScript” and “Page TSconfig” modules, but the search starts immediately when you write in the search field and not by clicking on the button. I would prefer adjustment in all places. If necessary, with a more general label such as “Search” (like already used in the “List” module). -
Jasmina Ließmann voted on patch set 3 CR -1 11/22/23, 13:44
-
Christian Rath-Ulrich commented on patch set 3 11/22/23, 13:54
i'm aware of that i'll gradually fix the other places as well. i don't think a generic label is so great. but i would join the consensus. -
Christian Rath-Ulrich commented on patch set 3 11/22/23, 15:01
Reply
i'm aware of that i'll gradually fix the other places as well. i don't think a generic label is so great. but i would join the consensus -
Christian Rath-Ulrich commented on patch set 3 11/22/23, 15:01
Reply
Done -
Simon Schaufelberger commented on patch set 3 CR -1 11/23/23, 07:56
must start with uppercase -
Annett Jähnichen commented on patch set 3 11/23/23, 11:17
I'm not sure, according to BIK, the icon should be sufficient as an explanation in a simple search form. Perhaps the title attribute on the button is not needed? In addition to the visible-hidden, both would be read out by the screen reader and would then be a duplication? The patch "Pass title from icon viewhelper to icon class" https://review.typo3.org/c/Packages/TYPO3.CMS/+/81679 could probably solve the problem of the description on the icon more globally? -
Jasmina Ließmann uploaded patch set 4
CR -1V +111/23/23, 12:16 -
Jasmina Ließmann updated the commit message in patch set 5 11/23/23, 12:18
-
core-ci voted on patch set 4 V +1 11/23/23, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49665
-
core-ci voted on patch set 5 V +1 11/23/23, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49666
-
Christian Rath-Ulrich commented on patch set 5 11/23/23, 13:06
Reply
Titles are not read aloud by screen readers unless you have activated this as an extra plugin. Therefore, only the title is not sufficient. However, I thought it could be quite practical for visually orientated users. -
Christian Rath-Ulrich voted on patch set 5 CR +1 V +1 11/27/23, 13:43
-
Christian Kuhn commented on patch set 5 11/27/23, 14:15
Reply
Done -
Michael Telgkamp commented on patch set 5 01/10/24, 08:14
List.html:54ReplyThe title attribute was introduced during the progress of this patch. It is not optimal and should be seen as a workaround to improve the situation for some users. More information and explanation regarding some accessibility concerns when using the title attribute: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title#accessibility_concerns. There is an additional problem to the ones mentioned on MDN and by Christian. When relying on the title attribute, any content of the button that is considered not empty by the browser, would overwrite the title attribute. In this specific case it is fine, because the icons are hidden by aria-hidden="true", but it might be different in other cases. In general: Some browser/screen reader combinations use the title attribute as label, when only the title attribute is available, but use it as description, when a label is available. For example Chrome exposes the following to the accessible DOM: Name: "Search" (derived from contents) aria-labelledby: Not specified (would overwrite previous - if set) aria-label: Not specified (would overwrite previous - if set) From label: Not specified (would overwrite previous - if set) Contents: "Search" (visually hidden Text, overwrites previous because it is set) title: "Search" (content of title attribute, not used because overwritten by content) Description: "Search" (content of title attribute, because title is overwritten by element contents) So in this case the screen reader would announce "Search - Button - Search". -
Christian Rath-Ulrich commented on patch set 5 01/30/24, 19:40
List.html:54Replyso the easiest way would be to remove the title again, right? -
Michael Telgkamp commented on patch set 5 CR +1 V +1 04/12/24, 07:54
List.html:54ReplyAs we discussed in other issues, for the moment the title attribute is considered as a temporary workaround to allow some tooltip like assistance for mouse users, while still not having an accessible tooltip in place. For the search icon it might be considerable that no text label is required, but in summary both is fine for me as a workaround / improvement of the current situation. I linked the Forge ticket with https://forge.typo3.org/issues/89872 (the tooltip ticket) to additionally keep track of this. -
Willi Wehmeier uploaded patch set 6
CR +1V +104/12/24, 08:19 -
Michael Telgkamp voted on patch set 6 CR +1 V +1 04/12/24, 08:22
-
core-ci voted on patch set 6 V +1 04/12/24, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55835
-
Jasmina Ließmann voted on patch set 6 CR +1 V +1 04/12/24, 08:49
-
Benjamin Kott voted on patch set 6 CR +2 V +2 04/16/24, 07:33
-
Andreas Kienast voted on patch set 6 CR +2 V +2 04/16/24, 08:52
-
Andreas Kienast merged patch set 7 04/16/24, 08:52
locallang.xlf:6