Review 12.4 Merged

81806[TASK] Propagate cache tags of cached page parts to page cache tags

Benjamin Franzke CR +2 V +2 Normal +58 −13 updated 11/20/23, 21:30

Commit message

When using the first-class TypoScript cache or stdWrap cache functions
the given cache tags of the content object are not correctly propagated
to pages on consecutive requests. The cache tags were not stored in the
cache entry, which is why they were never applied to the rendered page
cache once they were reused.

This patch adds support to store and restore the cache tag like #90775
did. Thus cache tags of subparts are now added as page cache tags.

[1] https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/Cache.html#cache-as-first-class-function

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 56

  1. Benjamin Franzke uploaded patch set 1 11/20/23, 16:21

  2. Benjamin Franzke voted on patch set 1 V +1 CR +1 11/20/23, 16:22

  3. core-ci voted on patch set 1 V +1 11/20/23, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49157

  4. Benjamin Franzke marked it work in progress 11/20/23, 16:29

  5. Benjamin Franzke commented on patch set 1 V +2 CR +2 11/20/23, 21:28

    This change is ready for review.
  6. Benjamin Franzke merged patch set 2 11/20/23, 21:30