Review main Merged

81807[TASK] Remove jQuery from @typo3/backend/drag-uploader

Andreas Nedbal CR +2 V +2 Hard +320 −310 updated 11/23/23, 17:48

Commit message

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2031

Show 36 earlier messages
  1. Andreas Nedbal uploaded patch set 1 11/20/23, 16:57

  2. Andreas Nedbal uploaded patch set 2 11/20/23, 17:00

  3. Andreas Nedbal uploaded patch set 3 11/20/23, 17:03

  4. core-ci voted on patch set 1 V -1 11/20/23, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49162

  5. core-ci voted on patch set 2 V +1 11/20/23, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49164

  6. core-ci voted on patch set 3 V +1 11/20/23, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49166

  1. Andreas Nedbal uploaded patch set 4 V +1 11/20/23, 17:17

  2. core-ci voted on patch set 4 V +1 11/20/23, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49169

  3. Andreas Nedbal uploaded patch set 5 V +1 11/20/23, 17:24

  4. core-ci voted on patch set 5 V +1 11/20/23, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49172

  5. Andreas Kienast commented on patch set 5 V -1 11/22/23, 09:42

    Drag&Drop upload in FormEngine is broken: ``` Uncaught TypeError: this.fileList.closest(...)?.find is not a function at DragUploader.processFiles (drag-uploader.js?bust=1700645131:13:6574) at DragUploader.handleDrop (drag-uploader.js?bust=1700645131:13:1653) at HTMLDivElement.<anonymous> (drag-uploader.js?bust=1700645131:13:4784) ```

    drag-uploader.ts:917

    This looks superfluous, can't we simply use `DragUploader.init()`?
  6. Andreas Nedbal uploaded patch set 6 V +1 11/22/23, 10:32

  7. core-ci voted on patch set 6 V +1 11/22/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49333

  8. Andreas Nedbal uploaded patch set 7 V +1 11/22/23, 10:52

  9. Andreas Nedbal commented on patch set 7 11/22/23, 10:52

    drag-uploader.ts:917 Reply

    Done
  10. core-ci voted on patch set 7 V -1 11/22/23, 11:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49335

  11. core-ci commented on patch set 7 11/22/23, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49335

  12. Andreas Kienast commented on patch set 7 11/22/23, 11:08

    drag-uploader.ts:251

    JSDoc is obsolete

    drag-uploader.ts:255

    I suggest to name this `irreObject`.

    dom-helper.ts:38

    I think, something like this (untested!) should also work: ``` const nextSiblings = []; let nextSibling = null; while ((nextSibling = target.nextElementSibling) !== null) { nextSiblings.push(nextSibling); } return nextSiblings; ```
  13. Andreas Nedbal commented on patch set 7 11/22/23, 11:57

    drag-uploader.ts:251 Reply

    Done

    drag-uploader.ts:255 Reply

    Done

    dom-helper.ts:38 Reply

    Done
  14. Andreas Nedbal uploaded patch set 8 V -1 11/22/23, 11:57

  15. core-ci voted on patch set 8 V +1 11/22/23, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49344

  16. Andreas Nedbal uploaded patch set 9 V +1 11/22/23, 12:07

  17. core-ci voted on patch set 9 V +1 11/22/23, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49345

  18. Andreas Kienast commented on patch set 9 11/22/23, 12:56

    drag-uploader.ts:744

    This method is unused (was already before).
  19. Andreas Nedbal uploaded patch set 10 V +1 11/22/23, 13:25

  20. Andreas Nedbal commented on patch set 10 11/22/23, 13:25

    drag-uploader.ts:744 Reply

    Done
  21. core-ci voted on patch set 10 V +1 11/22/23, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49349

  22. Andreas Kienast voted on patch set 10 CR +1 V +1 11/22/23, 13:34

  23. Jochen Roth voted on patch set 10 CR +1 V +1 11/23/23, 09:21

  24. Andreas Nedbal voted on patch set 10 CR +2 V +2 11/23/23, 17:48

  25. Andreas Nedbal merged patch set 11 11/23/23, 17:48