81807[TASK] Remove jQuery from @typo3/backend/drag-uploader
Commit message
Review
-
Code review CR +2 Done
- Andreas Nedbal +2
- Jochen Roth +1
- Andreas Kienast +1
-
Verified V +2 Done
- Andreas Nedbal +2
- Jochen Roth +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/utility/dom-helper.ts2+13 −0
- Build/Sources/TypeScript/backend/drag-uploader.ts8+304 −307
- typo3/sysext/backend/Resources/Public/JavaScript/utility/dom-helper.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+1 −1
- typo3/sysext/filelist/Resources/Private/Templates/File/List.html+1 −1
Review log 2031
Show 36 earlier messages
-
Andreas Nedbal uploaded patch set 1 11/20/23, 16:57
-
Andreas Nedbal uploaded patch set 2 11/20/23, 17:00
-
Andreas Nedbal uploaded patch set 3 11/20/23, 17:03
-
core-ci voted on patch set 1 V -1 11/20/23, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49162
-
core-ci voted on patch set 2 V +1 11/20/23, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49164
-
core-ci voted on patch set 3 V +1 11/20/23, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49166
-
Andreas Nedbal uploaded patch set 4
V +111/20/23, 17:17 -
core-ci voted on patch set 4 V +1 11/20/23, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49169
-
Andreas Nedbal uploaded patch set 5
V +111/20/23, 17:24 -
core-ci voted on patch set 5 V +1 11/20/23, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49172
-
Andreas Kienast commented on patch set 5 V -1 11/22/23, 09:42
Drag&Drop upload in FormEngine is broken: ``` Uncaught TypeError: this.fileList.closest(...)?.find is not a function at DragUploader.processFiles (drag-uploader.js?bust=1700645131:13:6574) at DragUploader.handleDrop (drag-uploader.js?bust=1700645131:13:1653) at HTMLDivElement.<anonymous> (drag-uploader.js?bust=1700645131:13:4784) ```drag-uploader.ts:917This looks superfluous, can't we simply use `DragUploader.init()`? -
Andreas Nedbal uploaded patch set 6
V +111/22/23, 10:32 -
core-ci voted on patch set 6 V +1 11/22/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49333
-
Andreas Nedbal uploaded patch set 7
V +111/22/23, 10:52 -
Andreas Nedbal commented on patch set 7 11/22/23, 10:52
drag-uploader.ts:917ReplyDone -
core-ci voted on patch set 7 V -1 11/22/23, 11:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49335
-
core-ci commented on patch set 7 11/22/23, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49335
-
Andreas Kienast commented on patch set 7 11/22/23, 11:08
drag-uploader.ts:251JSDoc is obsoletedrag-uploader.ts:255I suggest to name this `irreObject`.dom-helper.ts:38I think, something like this (untested!) should also work: ``` const nextSiblings = []; let nextSibling = null; while ((nextSibling = target.nextElementSibling) !== null) { nextSiblings.push(nextSibling); } return nextSiblings; ``` -
Andreas Nedbal commented on patch set 7 11/22/23, 11:57
drag-uploader.ts:251ReplyDonedrag-uploader.ts:255ReplyDonedom-helper.ts:38ReplyDone -
Andreas Nedbal uploaded patch set 8
V -111/22/23, 11:57 -
core-ci voted on patch set 8 V +1 11/22/23, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49344
-
Andreas Nedbal uploaded patch set 9
V +111/22/23, 12:07 -
core-ci voted on patch set 9 V +1 11/22/23, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49345
-
Andreas Kienast commented on patch set 9 11/22/23, 12:56
drag-uploader.ts:744This method is unused (was already before). -
Andreas Nedbal uploaded patch set 10
V +111/22/23, 13:25 -
Andreas Nedbal commented on patch set 10 11/22/23, 13:25
drag-uploader.ts:744ReplyDone -
core-ci voted on patch set 10 V +1 11/22/23, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49349
-
Andreas Kienast voted on patch set 10 CR +1 V +1 11/22/23, 13:34
-
Jochen Roth voted on patch set 10 CR +1 V +1 11/23/23, 09:21
-
Andreas Nedbal voted on patch set 10 CR +2 V +2 11/23/23, 17:48
-
Andreas Nedbal merged patch set 11 11/23/23, 17:48