Review main Merged

81809[TASK] Move cli command tests from acceptance to functional tests

Jochen Roth CR +2 V +2 Normal +89 −72 updated 11/21/23, 11:12

Commit message

Currently, cli commands are tested with codeception acceptance tests.
This takes quite some time to test all CLI commands available.

This has been change to run all CLI commands using functional testing
speeds up this process.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1320

  1. Jochen Roth uploaded patch set 1 11/20/23, 17:57

  2. Jochen Roth rebased onto patch set 2 11/20/23, 18:00

  3. core-ci voted on patch set 1 V -1 11/20/23, 18:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49176

  4. core-ci voted on patch set 2 V -1 11/20/23, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49177

  5. Jochen Roth uploaded patch set 3 V -1 11/20/23, 18:30

  6. core-ci voted on patch set 3 V -1 11/20/23, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49182

  7. Benjamin Franzke commented on patch set 3 11/20/23, 18:38

    v12 as well, please. (as we want to change acceptance testing for main and V12 to playwright)
  8. Jochen Roth uploaded patch set 4 V -1 11/20/23, 19:09

  9. core-ci voted on patch set 4 V +1 11/20/23, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49185

  10. Jochen Roth commented on patch set 4 11/20/23, 20:10

    Reply

    Done
  11. Christian Kuhn commented on patch set 4 CR -1 11/20/23, 21:18

    will run nightly on this to verify this does not trigger an acceptance test side effect due to reduced test sets which shuffle split stuff around.
  12. core-ci voted on patch set 4 V -1 11/20/23, 21:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49189

  13. Christian Kuhn rebased onto patch set 5 CR -1 V -1 11/21/23, 08:57

  14. core-ci voted on patch set 5 V +1 11/21/23, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49200

  15. core-ci commented on patch set 5 11/21/23, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49201

  16. Christian Kuhn voted on patch set 5 V +1 CR +1 11/21/23, 09:19

  17. Benjamin Franzke voted on patch set 5 V +1 CR +1 11/21/23, 09:38

  18. Oli Bartsch voted on patch set 5 V +1 CR +1 11/21/23, 09:42

  19. Christian Kuhn voted on patch set 5 V +2 CR +2 11/21/23, 09:50

  20. Christian Kuhn merged patch set 6 11/21/23, 11:12