81810[TASK] Remove jQuery from @typo3/backend/recordlist
Commit message
Review
-
Code review CR +2 Done
- Andreas Nedbal +2
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Andreas Nedbal +2
- Christian Kuhn +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2432
Show 57 earlier messages
-
Andreas Nedbal uploaded patch set 1 11/20/23, 18:51
-
core-ci voted on patch set 1 V +1 11/20/23, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49183
-
Oli Bartsch commented on patch set 1 CR -1 11/21/23, 08:56
recordlist.ts:114Might break in case "target" does not exist. Suggest to use "target?.dataset"recordlist.ts:119Might break in case "collapseIcon" does not exist. Suggest to use "collapseIcon?.dataset"recordlist.ts:218Please use either an empty string or the 'disabled' string, see https://www.w3.org/TR/2008/WD-html5-20080610/semantics.html#booleanrecordlist.ts:239Please add some check for element existence here. Plain JS behaves different than jQuery find() and friends, which do such checks internally. -
Andreas Nedbal uploaded patch set 2
CR -1V +111/21/23, 09:21 -
core-ci voted on patch set 2 V +1 11/21/23, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49204
-
Andreas Nedbal commented on patch set 2 11/21/23, 09:27
recordlist.ts:113ReplyThe targets here are generally div elements, so using plain HTMLElement as type should be finerecordlist.ts:114ReplyDonerecordlist.ts:119ReplyDonerecordlist.ts:218ReplyDonerecordlist.ts:239ReplyI added some additional checks, but generally this relies on existing (and mandatory) structure of recordlist panels. Where it makes sense I added existence checks and also cleaned up the row element list to remove empty/null elements. -
Andreas Kienast commented on patch set 2 CR -1 11/22/23, 09:35
recordlist.ts:215nopenopenopenoperecordlist.ts:216`currentTarget` does not exist.recordlist.ts:246Why is this required?recordlist.ts:251`tableElement.querySelector('tbody tr') === null` is a bit faster
-
Andreas Nedbal uploaded patch set 3
CR -1V +111/22/23, 10:07 -
Andreas Nedbal commented on patch set 3 11/22/23, 10:09
recordlist.ts:215ReplyDonerecordlist.ts:216ReplyDonerecordlist.ts:246ReplyRemoves anything that's null or false-y from the list, eliminates the need to do null checks for both elements in the initial querySelector. (technically, only `rowElement` would be removed anyway, as a spread empty array is nothing) Could add a comment to make that behaviour more obvious.recordlist.ts:251ReplyDone -
core-ci voted on patch set 3 V +1 11/22/23, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49329
-
Andreas Kienast commented on patch set 3 11/22/23, 10:27
recordlist.ts:246ReplyI'd rather do something like ``` const rowElements = translatedRowElements; if (rowElement !== null) { rowElements.unshift(rowElement); } ``` This safes a callback that potentially removes only one element at max. -
Andreas Kienast commented on patch set 3 11/22/23, 11:10
recordlist.ts:246ReplyAlternative: ``` [rowElement, ...translatedRowElements].forEach((rowElement: HTMLElement|null): void => { rowElement?.remove(); });``` -
Andreas Nedbal uploaded patch set 4
V +111/23/23, 13:24 -
core-ci voted on patch set 4 V +1 11/23/23, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49683
-
Andreas Nedbal commented on patch set 4 11/23/23, 13:43
recordlist.ts:246ReplyDone -
Andreas Kienast commented on patch set 4 CR -1 11/24/23, 08:34
on itrecordlist.ts:114ReplyPlease do not put null safe operators everywhere! We're rebuilding jQuery-behavior here and real errors may get hidden. -
Andreas Kienast uploaded patch set 5
CR -1V +111/24/23, 08:38 -
Andreas Kienast voted on patch set 5 CR +1 V +1 11/24/23, 08:38
-
core-ci voted on patch set 5 V +1 11/24/23, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49843
-
Jochen Roth uploaded patch set 6
CR +1V +111/24/23, 09:52 -
Jochen Roth voted on patch set 6 CR +1 V +1 11/24/23, 09:54
-
Christian Kuhn voted on patch set 6 CR +1 V +1 11/24/23, 10:25
-
Andreas Kienast voted on patch set 6 CR +1 V +1 11/24/23, 10:28
-
core-ci voted on patch set 6 V -1 11/24/23, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49864
-
Jochen Roth uploaded patch set 7
CR +1V +111/24/23, 10:33 -
Andreas Kienast uploaded patch set 8 11/24/23, 10:33
-
core-ci voted on patch set 7 V +1 11/24/23, 10:41 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 8 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49872
-
Andreas Kienast voted on patch set 8 CR +1 V +1 11/24/23, 10:42
-
Christian Kuhn voted on patch set 8 CR +1 V +1 11/24/23, 10:43
-
core-ci voted on patch set 8 V +1 11/24/23, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49873
-
Andreas Nedbal voted on patch set 8 CR +2 V +2 11/24/23, 10:45
-
Andreas Nedbal merged patch set 9 11/24/23, 10:45
recordlist.ts:113