Review main Merged

81811[TASK] Exclude thumbnails from screen readers in file list module

Christian Rath-Ulrich CR +2 V +2 Easy +3 −2 updated 01/05/24, 10:02

Commit message

In the file list module, a file thumbnail does not contain
alternative text. To exclude these thumbnails from screen
readers and thus improve accessibility, an empty `alt`
tag is set. This applies to both the list and tile view.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 3036

Show 911 earlier messages
  1. Christian Rath-Ulrich uploaded patch set 1 11/20/23, 19:29

  2. core-ci voted on patch set 1 V +1 11/20/23, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49187

  3. Willi Wehmeier voted on patch set 1 V +1 CR +1 11/21/23, 07:32

  4. Garvin Hicking commented on patch set 1 11/21/23, 07:39

    Could the alt-attribute maybe be set to something like "Thumbnail of file xxxx", that would allow screenreaders to ingeract with it properly, if I understand correctly?
  5. Willi Wehmeier commented on patch set 1 11/21/23, 13:07

    Reply

    I'm not sure if this helps in terms of accessibility. The filename itself is visible to screenreaders and the information, that the picture is a thumbnail of the file with name xxxx doesn't add any value to the person accessing the site with a screenreader. This is just my personal opinion and I'm open to other opinions :)
  6. Garvin Hicking commented on patch set 1 V +1 CR +1 11/22/23, 11:21

    Reply

    Ah, now I fully understand the intention. I'm sorry I misread that. Because the intent is to really "hide" the image from the screenreader, so an empty value is exactly what's needed. :-D
  7. Christian Rath-Ulrich commented on patch set 1 11/22/23, 11:48

    Reply

    But that comes with the assumption that the filename is more than "2023-02-32.png" which is also Wath is written next to the image
  8. Jasmina Ließmann updated the commit message in patch set 2 CR +1 V +1 11/23/23, 11:44

  9. core-ci voted on patch set 2 V +1 11/23/23, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49651

  10. Jasmina Ließmann voted on patch set 2 CR +1 V +1 11/23/23, 11:52

  11. Garvin Hicking voted on patch set 2 CR +1 V +1 11/23/23, 12:31

  1. Jörg Bösche voted on patch set 2 CR +1 11/30/23, 12:45

  2. Patrick Schriner uploaded patch set 3 CR +1 V +1 12/04/23, 10:29

  3. core-ci voted on patch set 3 V +1 12/04/23, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50314

  4. Oliver Klee voted on patch set 3 CR +1 12/04/23, 10:51

  5. Oli Bartsch commented on patch set 3 CR -1 12/04/23, 11:27

    FileList.php:675

    I suggest to use the actually set alternative from the file here as it's done automatically for the tiles view. The property can be retrieved with e.g.: `$resourceView->getPreview()->getProperty('alternative')`.

    Tiles.html:68

    This is not necessary. The ImageViewHelper applies an empty alt automatically anyways, see: https://github.com/TYPO3/typo3/blob/main/typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php#L203
  6. Christian Rath-Ulrich uploaded patch set 4 CR +1 V +1 12/06/23, 10:17

  7. Christian Rath-Ulrich commented on patch set 3 12/06/23, 10:17

    FileList.php:675 Reply

    i have discussed this with a bik tester as well as with real people concerned and we have come to the conclusion that a speaking alt-label is not useful here. as it does not contribute to orientation.

    Tiles.html:68 Reply

    yes here my browser has screwed me up in the display i'll fix it
  8. core-ci voted on patch set 4 V +1 12/06/23, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50410

  9. Oliver Klee voted on patch set 4 CR +1 12/06/23, 10:56

  10. Jasmina Ließmann uploaded patch set 5 CR +1 V +1 12/06/23, 11:01

  11. Christian Rath-Ulrich voted on patch set 5 CR +1 V +1 12/06/23, 11:04

  12. core-ci voted on patch set 5 V +1 12/06/23, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50413

  13. Garvin Hicking voted on patch set 5 CR +1 V +1 12/06/23, 14:19

  14. Oliver Klee voted on patch set 5 CR +1 12/06/23, 15:34

  15. Jasmina Ließmann voted on patch set 5 CR +1 V +1 12/06/23, 15:43

  16. Oli Bartsch commented on patch set 5 12/07/23, 08:44

    FileList.php:675 Reply

    So we should then somehow adjust the tiles template, because if a alternative text is set, it will be used by the ImageViewHelper. This will therefore be inconsistent if we always use an empty alt attribute here, but depending on the actual meta data, might render the alt attribute with a text in the tiles view.
  17. Oli Bartsch voted on patch set 5 CR -1 12/07/23, 14:47

  18. Christian Rath-Ulrich commented on patch set 5 12/14/23, 19:05

    FileList.php:675 Reply

    Any ideas how to achieve this?
  19. Oli Bartsch commented on patch set 5 01/02/24, 10:32

    FileList.php:675 Reply

    I've done a pre patch to allow such behaviour in the ImageViewHelper https://review.typo3.org/c/Packages/TYPO3.CMS/+/82295
  20. Oli Bartsch uploaded patch set 6 CR +1 V +1 01/05/24, 09:12

  21. Oli Bartsch commented on patch set 6 CR +1 V +1 01/05/24, 09:13

    FileList.php:675 Reply

    Done
  22. core-ci voted on patch set 6 V +1 01/05/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51129

  23. Jasmina Ließmann voted on patch set 6 CR +1 V +1 01/05/24, 09:26

  24. Oli Bartsch voted on patch set 6 CR +2 V +2 01/05/24, 10:02

  25. Oli Bartsch merged patch set 7 01/05/24, 10:02