Review main Merged

81816[TASK] Modify handling of prefixed server version information

Stefan Bürk CR +2 V +2 Normal +62 −30 updated 11/21/23, 12:46

Commit message

Doctrine DBAL deprecated the `ServerInfoAwareConnection`
and `VersionAwarePlatformDriver` interfaces within `3.x`
and force all Driver and DriverConnection to implement
the APIs aware of the server version [1].

TYPO3 used the server version and prefixed them, which
will no longer work with the next Doctrine DBAL major
to due the call chain. The prefixed version has been
used in several places within the reporting module and
backend information to display database vendor aware
information.

This change adds a new `getPlatformServerVersion()`
method to the core connection class and removes the
prefixing from the `getServerVersion()` methods. All
usages in userland code are modified to use the new
method. Additionally, tests are aligned to this change.

[1] https://github.com/doctrine/dbal/blob/3.8.x/UPGRADE.md#deprecated-driver-level-apis-that-dont-take-the-server-version-into-account

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 14