Review main Merged

81818[TASK] Show error message when Install Tool password is empty

Torben Hansen CR +2 V +2 Easy +11 −17 updated 11/21/23, 18:04

Commit message

When `$GLOBALS['TYPO3_CONF_VARS']['BE']['installToolPassword']` is
empty, the Install Tool does not handle the request resulting in a
404 response,  when the Install Tool is accessed.

Instead of showing a 404 error, a response with an appropriate error
message should be returned, so the user knows why the Install Tool
could not be initialized.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Torben Hansen uploaded patch set 1 11/21/23, 12:19

  2. core-ci voted on patch set 1 V +1 11/21/23, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49221

  3. Oliver Hader voted on patch set 1 CR +1 11/21/23, 12:26

  4. Oliver Klee voted on patch set 1 CR +1 11/21/23, 12:30

  5. Christian Kuhn uploaded patch set 2 CR +1 V +1 11/21/23, 12:45

  6. core-ci voted on patch set 2 V +1 11/21/23, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49227

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 11/21/23, 12:55

  8. Benjamin Franzke uploaded patch set 3 CR +1 V +1 11/21/23, 17:42

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 11/21/23, 17:43

  10. core-ci voted on patch set 3 V +1 11/21/23, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49272

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 11/21/23, 18:04

  12. Christian Kuhn merged patch set 4 11/21/23, 18:04