Review main Merged

81824[TASK] Remove jQuery from workspaces record table

Andreas Nedbal CR +2 V +2 Hard +572 −236 updated 06/30/25, 16:19

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 1725

  1. Andreas Nedbal uploaded patch set 1 11/21/23, 16:03

  2. Andreas Nedbal uploaded patch set 2 11/21/23, 16:04

  3. core-ci voted on patch set 1 V -1 11/21/23, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49253

  4. core-ci voted on patch set 2 V -1 11/21/23, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49254

  5. Andreas Nedbal uploaded patch set 3 V -1 11/21/23, 16:17

  6. core-ci voted on patch set 3 V +1 11/21/23, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49258

  7. Andreas Nedbal uploaded patch set 4 V +1 11/21/23, 18:56

  8. core-ci voted on patch set 4 V +1 11/21/23, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49288

  9. Andreas Nedbal rebased onto patch set 5 V +1 11/21/23, 20:39

  10. core-ci voted on patch set 5 V +1 11/21/23, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49298

  11. Andreas Kienast commented on patch set 5 V -1 CR -1 11/22/23, 09:26

    The element to toggle records looks broken, the sorting arrows moves below the control.

    icon-helper.ts:23

    Please remove the indentation
  12. Andreas Nedbal uploaded patch set 6 CR -1 V +1 11/22/23, 09:50

  13. core-ci voted on patch set 6 V +1 11/22/23, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49325

  14. Andreas Nedbal commented on patch set 6 11/22/23, 18:01

    icon-helper.ts:23 Reply

    Done
  15. Andreas Nedbal uploaded patch set 7 V +1 11/22/23, 18:14

  16. core-ci voted on patch set 7 V +1 11/22/23, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49416

  17. Jochen Roth commented on patch set 7 CR -1 V -1 11/22/23, 21:19

    "Publish version of record" breaks the table view. In some cases it only displays a single record. After a manual reload it displays again.
  18. Andreas Nedbal uploaded patch set 8 CR -1 V +1 11/23/23, 12:19

  19. core-ci voted on patch set 8 V +1 11/23/23, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49670

  20. Jochen Roth voted on patch set 8 CR +1 V +1 11/23/23, 13:47

  21. Benni Mack voted on patch set 8 CR +2 V +2 12/12/23, 22:11

  22. Benni Mack merged patch set 9 12/12/23, 22:11

  23. Christian Kuhn commented on patch set 9 06/25/25, 01:42

    record-table.js:113

    the previous solution had an 'indentation' solution here to nest-in "sub records" like inline children. this vanished with the patch.
  24. Benni Mack commented on patch set 9 06/25/25, 07:14

    record-table.js:113 Reply Unresolved

    Oh my... We should bring that back... Can you create an issue please?
  25. Christian Kuhn commented on patch set 9 06/30/25, 16:19