Review 12.4 Merged

81830[TASK] Show error message when Install Tool password is empty

Christian Kuhn CR +2 V +2 Easy +11 −17 updated 11/21/23, 18:04

Commit message

When `$GLOBALS['TYPO3_CONF_VARS']['BE']['installToolPassword']` is
empty, the Install Tool does not handle the request resulting in a
404 response,  when the Install Tool is accessed.

Instead of showing a 404 error, a response with an appropriate error
message should be returned, so the user knows why the Install Tool
could not be initialized.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn uploaded patch set 1 11/21/23, 17:54

  2. core-ci voted on patch set 1 V +1 11/21/23, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49279

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 11/21/23, 18:04

  4. Christian Kuhn merged patch set 2 11/21/23, 18:04