Review main Merged

81834[BUGFIX] Set default value for command description

Tim Weisenberger CR +2 V +2 Normal +69 −1 updated 11/22/23, 08:23

Commit message

The function `TextDescriptor::describeApplication` did throw an
unhandled exception if the TYPO3 CMS installation had a registered
CLI command without a description.

This has now been fixed. In case a command has no description defined
an empty string is used.

Additionally, some tests were added.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 813

  1. Tim Weisenberger uploaded patch set 1 11/21/23, 20:37

  2. core-ci voted on patch set 1 V -1 11/21/23, 20:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49297

  3. Tim Weisenberger uploaded patch set 2 V -1 11/21/23, 21:24

  4. Tim Weisenberger uploaded patch set 3 11/21/23, 21:26

  5. core-ci voted on patch set 2 V -1 11/21/23, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49303

  6. Tim Weisenberger uploaded patch set 4 11/21/23, 21:33

  7. core-ci voted on patch set 3 V -1 11/21/23, 21:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49305

  8. core-ci voted on patch set 4 V +1 11/21/23, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49306

  9. Benjamin Franzke uploaded patch set 5 V +1 11/22/23, 07:42

  10. core-ci voted on patch set 5 V +1 11/22/23, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49314

  11. Oliver Klee voted on patch set 5 V +1 CR +1 11/22/23, 08:10

  12. Benjamin Franzke voted on patch set 5 V +2 CR +2 11/22/23, 08:12

  13. Benjamin Franzke merged patch set 6 11/22/23, 08:23