Review main Merged

81835[TASK] Remove jQuery from workspaces history view

Andreas Nedbal CR +2 V +2 Normal +159 −56 updated 03/04/24, 11:36

Commit message

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1114

  1. Andreas Nedbal uploaded patch set 1 11/21/23, 21:16

  2. core-ci voted on patch set 1 V +1 11/21/23, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49302

  3. Andreas Nedbal rebased onto patch set 2 V +1 03/04/24, 08:31

    The following files contain Git conflicts: * Build/Sources/TypeScript/workspaces/backend.ts * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js
  4. core-ci voted on patch set 2 V -1 03/04/24, 08:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53811

  5. Andreas Nedbal uploaded patch set 3 V -1 03/04/24, 08:40

  6. Andreas Nedbal marked it ready for review 03/04/24, 08:40

  7. core-ci voted on patch set 3 V +1 03/04/24, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53812

  8. Andreas Kienast commented on patch set 3 CR -1 03/04/24, 10:51

    history-view.ts:18

    I kinda dislike the cross-dependency between history-view.ts <> backend.ts
  9. Andreas Kienast commented on patch set 3 CR +1 V +1 03/04/24, 10:52

    history-view.ts:18 Reply

    Never mind, I didn't notice https://review.typo3.org/c/Packages/TYPO3.CMS/+/83188, which resolves said dep.
  10. Andreas Nedbal commented on patch set 3 03/04/24, 10:57

    history-view.ts:18 Reply

    It's there because Diff is used by another element as well. In https://review.typo3.org/c/Packages/TYPO3.CMS/+/83188 I move the Diff type into the DiffView component and export it from there.
  11. Andreas Nedbal commented on patch set 3 03/04/24, 10:57

    history-view.ts:18 Reply

    Done
  12. Stefan Bürk voted on patch set 3 CR +1 V +1 03/04/24, 11:32

  13. Andreas Nedbal voted on patch set 3 CR +2 V +2 03/04/24, 11:36

  14. Andreas Nedbal merged patch set 4 03/04/24, 11:36