Review main Merged

81852[TASK] Automatically remove containers in runTests.sh

Benjamin Franzke CR +2 V +2 Normal +26 −31 updated 11/23/23, 17:24

Commit message

Removing all containers will remove their dangling volumes
automatically and we can drop the manual cleanup.

Parameters have been applied via:
  sed -i '/CONTAINER_COMMON_PARAMS/!s/\${CONTAINER_BIN} run/& --rm/' \
    Build/Scripts/runTests.sh

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1014

  1. Benjamin Franzke uploaded patch set 1 11/22/23, 13:48

  2. core-ci voted on patch set 1 V +1 11/22/23, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49351

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 11/22/23, 15:43

  4. Nikita Hovratov voted on patch set 1 CR +1 V +1 11/22/23, 16:36

  5. Stefan Bürk commented on patch set 1 CR -2 11/22/23, 20:49

    temp -2 due to coordination with other changes
  6. core-ci voted on patch set 1 V -1 11/23/23, 16:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49719

  7. core-ci commented on patch set 1 11/23/23, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49789

  8. Stefan Bürk voted on patch set 1 CR 0 V 0 11/23/23, 17:05

  9. Benjamin Franzke rebased onto patch set 2 CR +1 V +1 11/23/23, 17:05

  10. Christian Kuhn voted on patch set 2 CR +1 V +1 11/23/23, 17:11

  11. core-ci voted on patch set 2 V +1 11/23/23, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49795

  12. Stefan Bürk voted on patch set 2 CR +1 V +1 11/23/23, 17:24

  13. Christian Kuhn voted on patch set 2 CR +2 V +2 11/23/23, 17:24

  14. Christian Kuhn merged patch set 3 11/23/23, 17:24