81854[TASK] Add pagetitle to tooltip on page icon in treeview
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Kott +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1720
-
Willi Wehmeier uploaded patch set 1 11/22/23, 14:15
-
core-ci voted on patch set 1 V +1 11/22/23, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49358
-
Garvin Hicking commented on patch set 1 12/06/23, 12:21
Personally, for me the "UID" is what I need at that place very often. With the current implementation, the tooltip would vary in length and I would need to skip to the end of a title to see that information. Would it be acceptable to have the "id=XXX" part set in front of the page title, so it's always the leading information at a fixed place? -
Willi Wehmeier uploaded patch set 2
V +112/08/23, 11:44 -
Willi Wehmeier commented on patch set 2 12/08/23, 11:47
Reply
Good point. The usual use case shouldn't get affected by accessibility improvements. I switched the order and put the title right behind the uid info. -
core-ci voted on patch set 2 V +1 12/08/23, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50491
-
Garvin Hicking commented on patch set 2 12/08/23, 11:57
Reply
Thanks! I'm wondering - the text right next to the icon also contains the pagetitle - would screenreaders then read out the title twice? Once as a placeholder for the icon and once because it's actual text next to it? Would maybe an aria reference to that element next to it be preferrable instead of "inling" a title attribute? -
Willi Wehmeier commented on patch set 2 12/11/23, 07:16
Reply
The text right next to the icon does not get read out by screenreaders. Probably because it's just a <text> node inside of the svg tree. That's why I think we should stick to this solution to have a proper <title> tag 😊 -
Christian Rath-Ulrich voted on patch set 2 CR +1 V +1 01/08/24, 12:37
-
Oli Bartsch voted on patch set 2 CR +1 01/08/24, 15:22
-
Kai Ole Hartwig voted on patch set 2 CR +1 01/24/24, 09:23
-
Kai Ole Hartwig voted on patch set 2 V +1 01/24/24, 09:23
-
Guido Schmechel commented on patch set 2 CR +1 V +1 01/27/24, 21:47
Successfully tested the tooltip, but not with a screenreader. Manipulated some JSON data for the fetchData route, but no success -
Benjamin Kott commented on patch set 2 CR -1 V -1 03/01/24, 06:45
- misses nav-title usage - does not include title on root node on it -
Benjamin Kott uploaded patch set 3
CR +1V +103/01/24, 06:54 -
Benjamin Kott commented on patch set 3 03/01/24, 06:55
Reply
Done -
core-ci voted on patch set 3 V +1 03/01/24, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53740
-
Benjamin Kott voted on patch set 3 CR +1 V +1 03/01/24, 07:33
-
Oli Bartsch voted on patch set 3 CR +2 V +2 03/01/24, 13:51
-
Oli Bartsch merged patch set 4 03/01/24, 13:51