Review main Merged

81856[BUGFIX] Suppress command output in functional tests

Jochen Roth CR +2 V +2 Normal +48 −33 updated 11/22/23, 21:01

Commit message

In #102417 the cli tests were moved to functional
tests. This leads to (unwanted) additional on top of
the dot output in the functional tests.

This has been fixed by using proc_open to catch
the output of the progressbar and friends. Also
the args argument is fixed to allow for multiple
arguments to be used in the data provider.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2236

Show 611 earlier messages
  1. Jochen Roth uploaded patch set 1 11/22/23, 14:51

  2. core-ci voted on patch set 1 V -1 11/22/23, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49367

  3. Jochen Roth uploaded patch set 2 V -1 11/22/23, 14:59

  4. Jochen Roth uploaded patch set 3 11/22/23, 15:01

  5. Jochen Roth uploaded patch set 4 11/22/23, 15:03

  6. Jochen Roth uploaded patch set 5 11/22/23, 15:05

  7. core-ci voted on patch set 3 V -1 11/22/23, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49372

  8. core-ci voted on patch set 2 V +1 11/22/23, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49370

  9. core-ci voted on patch set 4 V -1 11/22/23, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49373

  10. Jochen Roth uploaded patch set 6 11/22/23, 15:15

  11. core-ci voted on patch set 5 V -1 11/22/23, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49374

  1. Jochen Roth updated the commit message in patch set 7 11/22/23, 15:17

  2. core-ci voted on patch set 6 V -1 11/22/23, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49375

  3. core-ci voted on patch set 7 V -1 11/22/23, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49377

  4. core-ci commented on patch set 7 11/22/23, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49377

  5. Jochen Roth uploaded patch set 8 V -1 11/22/23, 15:36

  6. core-ci voted on patch set 8 V +1 11/22/23, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49381

  7. Andreas Kienast rebased onto patch set 9 V +1 11/22/23, 15:43

  8. Andreas Kienast rebased onto patch set 10 11/22/23, 15:50

  9. core-ci voted on patch set 9 V -1 11/22/23, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49383

  10. Andreas Kienast rebased onto patch set 11 11/22/23, 16:00

  11. core-ci voted on patch set 10 V -1 11/22/23, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49388

  12. core-ci voted on patch set 11 V +1 11/22/23, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49391

  13. Stefan Bürk voted on patch set 11 CR -1 11/22/23, 17:32

  14. Jochen Roth uploaded patch set 12 CR -1 V +1 11/22/23, 17:47

  15. Jochen Roth commented on patch set 12 11/22/23, 17:49

    @stefan@buerk.tech Thanks for the review. As discussed, changed pipes to "w" and added comments so people know where to look for more/detailed information.
  16. core-ci voted on patch set 12 V +1 11/22/23, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49411

  17. Stefan Bürk voted on patch set 12 CR -1 11/22/23, 18:03

  18. Benjamin Franzke uploaded patch set 13 CR -1 V +1 11/22/23, 18:51

  19. Benjamin Franzke voted on patch set 13 CR +1 V +1 11/22/23, 18:51

  20. core-ci voted on patch set 13 V +1 11/22/23, 18:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49443

  21. Jochen Roth voted on patch set 13 CR +1 V +1 11/22/23, 19:46

  22. Andreas Kienast voted on patch set 13 CR +1 V +1 11/22/23, 19:59

  23. Stefan Bürk voted on patch set 13 CR -1 11/22/23, 20:15

  24. Stefan Bürk voted on patch set 13 CR +2 V +2 11/22/23, 20:18

  25. Stefan Bürk merged patch set 14 11/22/23, 21:01