Review main Merged

81860[BUGFIX] Do not convert additional attributes

Oli Bartsch CR +2 V +2 Normal +26 −26 updated 11/22/23, 16:40

Commit message

Additional attributes of contect menu items
should not be converted by htmlspecialchars(),
because they will be escaped on returning the
JsonResponse, due to the used flags and are
additionally set using the DOM API.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1317

  1. Oli Bartsch uploaded patch set 1 11/22/23, 15:23

  2. Christoph Lehmann voted on patch set 1 CR +1 V +1 11/22/23, 15:27

  3. core-ci voted on patch set 1 V +1 11/22/23, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49378

  4. Jasmina Ließmann voted on patch set 1 CR +1 V +1 11/22/23, 15:34

  5. Oli Bartsch uploaded patch set 2 CR +1 V +1 11/22/23, 15:49

  6. Oli Bartsch updated the commit message in patch set 3 11/22/23, 15:50

  7. Jasmina Ließmann voted on patch set 3 CR +1 V +1 11/22/23, 15:52

  8. Annett Jähnichen voted on patch set 3 CR +1 V +1 11/22/23, 15:55

  9. core-ci voted on patch set 3 V +1 11/22/23, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49389

  10. Oli Bartsch uploaded patch set 4 CR +1 V +1 11/22/23, 16:24

  11. Oli Bartsch uploaded patch set 5 11/22/23, 16:26

  12. Jasmina Ließmann voted on patch set 5 CR +1 V +1 11/22/23, 16:28

  13. core-ci voted on patch set 4 V +1 11/22/23, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49397

  14. core-ci voted on patch set 5 V +1 11/22/23, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49399

  15. Oliver Hader voted on patch set 5 CR +1 V +1 11/22/23, 16:35

  16. Oli Bartsch voted on patch set 5 CR +2 V +2 11/22/23, 16:40

  17. Oli Bartsch merged patch set 6 11/22/23, 16:40