Review main Merged

81862[TASK] Extract ext_localconf.php loading to a factory

Torben Hansen CR +2 V +2 Hard +127 −257 updated 11/26/23, 10:43

Commit message

Having ext_localconf.php loading related code within
static ExtensionManagementUtility is unflexible and no
good architecture.

The patch extracts ext_localconf.php loading to a factory
used by bootstrap for the different scopes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1726

Show 1 earlier messages
  1. Torben Hansen uploaded patch set 1 11/22/23, 15:49

  1. core-ci voted on patch set 1 V -1 11/22/23, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49386

  2. Torben Hansen uploaded patch set 2 V -1 11/22/23, 16:35

  3. core-ci voted on patch set 2 V +1 11/22/23, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49400

  4. Torben Hansen wrote 11/23/23, 08:49

    Topic set to extbase
  5. Torben Hansen wrote 11/23/23, 10:17

    Topic extbase removed
  6. Torben Hansen uploaded patch set 3 V +1 11/23/23, 12:18

  7. Torben Hansen uploaded patch set 4 11/23/23, 12:19

  8. core-ci voted on patch set 4 V +1 11/23/23, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49669

  9. core-ci voted on patch set 3 V -1 11/23/23, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49667

  10. Torben Hansen rebased onto patch set 5 V +1 11/25/23, 11:21

  11. core-ci voted on patch set 5 V +1 11/25/23, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49918

  12. Christian Kuhn commented on patch set 5 CR -1 11/25/23, 14:59

    yay! will update some details.
  13. Christian Kuhn uploaded patch set 6 CR -1 V +1 11/26/23, 09:52

  14. core-ci voted on patch set 6 V -1 11/26/23, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49942

  15. Christian Kuhn uploaded patch set 7 V -1 11/26/23, 09:58

  16. Christian Kuhn uploaded patch set 8 11/26/23, 10:03

  17. core-ci voted on patch set 7 V -1 11/26/23, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49943

  18. Christian Kuhn uploaded patch set 9 11/26/23, 10:05

  19. core-ci voted on patch set 8 V -1 11/26/23, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49944

  20. core-ci voted on patch set 9 V +1 11/26/23, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49945

  21. Christian Kuhn voted on patch set 9 CR +1 V +1 11/26/23, 10:13

  22. Oliver Klee voted on patch set 9 V +1 11/26/23, 10:31

  23. Oliver Klee voted on patch set 9 CR +1 11/26/23, 10:41

  24. Christian Kuhn voted on patch set 9 CR +2 V +2 11/26/23, 10:42

  25. Christian Kuhn merged patch set 10 11/26/23, 10:43