Review main Merged

81864[BUGFIX] Avoid strict type exception in Import

Nikita Hovratov CR +2 V +2 Easy +2 −2 updated 11/22/23, 21:40

Commit message

$tokenizedContent could be null and would already cause an undefined
array key warning. When passed to the strlen method, this even causes
an exception.

This patch adds a null coalesce operator with an empty string as default
and replaces the odd strlen bool expression with a strict comparison to
an empty string.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Nikita Hovratov uploaded patch set 1 11/22/23, 16:24

  2. core-ci voted on patch set 1 V +1 11/22/23, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49398

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 11/22/23, 20:36

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 11/22/23, 21:40

  5. Christian Kuhn merged patch set 2 11/22/23, 21:40