Review 12.4 Merged

81865[BUGFIX] Do not convert additional attributes

Oli Bartsch CR +2 V +2 Easy +25 −25 updated 11/22/23, 16:58

Commit message

Additional attributes of contect menu items
should not be converted by htmlspecialchars(),
because they will be escaped on returning the
JsonResponse, due to the used flags and are
additionally set using the DOM API.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 34

  1. Oli Bartsch uploaded patch set 1 11/22/23, 16:44

  2. core-ci voted on patch set 1 V +1 11/22/23, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49401

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 11/22/23, 16:58

  4. Oli Bartsch merged patch set 2 11/22/23, 16:58