Review main Merged

81869[TASK] Hide buttons with no impact

Annett Jähnichen CR +2 V +2 Easy +12 −6 updated 11/22/23, 19:50

Commit message

When a pagetree were created in the styleguide extension
the create or delete button is actually disabled, but visible.
This change hides buttons with no clickable action.
And shows the button with the possible action.

Review

  • Code review CR +2 Done
    • Annett Jähnichen +2
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Annett Jähnichen +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1317

  1. Annett Jähnichen uploaded patch set 1 11/22/23, 17:36

  2. core-ci voted on patch set 1 V +1 11/22/23, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49409

  3. Jochen Roth voted on patch set 1 CR +1 V +1 11/22/23, 17:52

  4. Andreas Kienast commented on patch set 1 CR -1 11/22/23, 18:21

    This is either a TASK or a BUGFIX, but no feature. This would also miss the ReST file.

    processing-indicator.ts:48

    Why do we need a new CSS class? Can't we use the `hidden` attribute instead?
  5. Jochen Roth commented on patch set 1 11/22/23, 18:54

    processing-indicator.ts:48 Reply

    on it
  6. Jochen Roth uploaded patch set 2 CR +1 V +1 11/22/23, 19:30

  7. Jochen Roth commented on patch set 2 CR +1 V +1 11/22/23, 19:32

    processing-indicator.ts:48 Reply

    Done
  8. Andreas Kienast updated the commit message in patch set 3 CR +1 V +1 11/22/23, 19:37

  9. core-ci voted on patch set 2 V +1 11/22/23, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49483

  10. Andreas Kienast commented on patch set 3 11/22/23, 19:38

    processing-indicator.ts:48

    `target.hidden = true`?
  11. core-ci voted on patch set 3 V +1 11/22/23, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49491

  12. Andreas Kienast uploaded patch set 4 V +1 11/22/23, 19:43

  13. Andreas Kienast commented on patch set 4 CR +1 V +1 11/22/23, 19:43

    processing-indicator.ts:48 Reply

    Done
  14. Jochen Roth voted on patch set 4 CR +1 V +1 11/22/23, 19:46

  15. core-ci voted on patch set 4 V +1 11/22/23, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49495

  16. Annett Jähnichen voted on patch set 4 CR +2 V +2 11/22/23, 19:50

  17. Annett Jähnichen merged patch set 5 11/22/23, 19:50