Review main Merged

81870[TASK] Remove `COMPOSER_ALLOW_SUPERUSER=1` from runTests.sh

Stefan Bürk CR +2 V +2 Easy +3 −3 updated 11/23/23, 15:01

Commit message

The environment variable `COMPOSER_ALLOW_SUPERUSER` has been set for
composer command runs to avoid the warning that you are root in the
container.

It has been added to the core-testing-phpXY images so it is now
superflous to set it explicitly on container invocation and can be
removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stephan Großberndt +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 1218

  1. Stefan Bürk uploaded patch set 1 11/22/23, 18:17

  2. core-ci voted on patch set 1 V +1 11/22/23, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49417

  3. Benjamin Franzke commented on patch set 1 CR -1 11/22/23, 20:01

    COMPOSER_ALLOW_SUPERUSER
  4. Stefan Bürk updated the commit message in patch set 2 CR -1 V +1 11/23/23, 11:55

  5. Stefan Bürk updated the commit message in patch set 3 11/23/23, 11:55

  6. Stefan Bürk commented on patch set 3 11/23/23, 11:56

    Reply

    Acknowledged
  7. core-ci voted on patch set 2 V +1 11/23/23, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49656

  8. core-ci voted on patch set 3 V +1 11/23/23, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49657

  9. Stefan Bürk updated the commit message in patch set 4 V +1 11/23/23, 12:12

  10. core-ci voted on patch set 4 V +1 11/23/23, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49661

  11. Garvin Hicking updated the commit message in patch set 5 V +1 11/23/23, 14:13

  12. Garvin Hicking voted on patch set 5 CR +1 V +1 11/23/23, 14:14

  13. core-ci voted on patch set 5 V +1 11/23/23, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49700

  14. Stephan Großberndt updated the commit message in patch set 6 CR +1 V +1 11/23/23, 14:21

  15. Stephan Großberndt voted on patch set 6 CR +1 11/23/23, 14:21

  16. core-ci voted on patch set 6 V +1 11/23/23, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49702

  17. Christian Kuhn voted on patch set 6 CR +2 V +2 11/23/23, 15:01

  18. Christian Kuhn merged patch set 7 11/23/23, 15:01