Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

81871[TASK] Cache results in BackendUtility::getRecordTitle

Christian Eßl CR 0 V -1 Easy +33 −0 updated 03/27/25, 17:36

Commit message

Use a runtime cache to cache  the record titles in
BackendUtility::getRecordTitle. This is especially useful
(but not limited to) in backend forms for records with
many inline children and can vastly speed up their rendering.

These scenarios include:
- Inline children that reference their parent in "label_alt"
- Inline children that reference their parent in a TCA field
of type "select".

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 8
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/71/81871/8 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/71/81871/8 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Issues 4

Files 3

Review log 1422

  1. Christian Eßl uploaded patch set 1 11/22/23, 19:29

  2. Christian Eßl updated the commit message in patch set 2 11/22/23, 19:30

  3. core-ci voted on patch set 2 V +1 11/22/23, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49480

  4. core-ci voted on patch set 1 V +1 11/22/23, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49479

  5. Benni Mack commented on patch set 2 11/22/23, 19:39

    AbstractItemProvider.php:387

    how about moving the cache to inside of the getRecordTitle method?
  6. Andreas Kienast voted on patch set 2 CR +1 11/22/23, 19:40

  7. Christian Eßl commented on patch set 2 11/22/23, 19:57

    AbstractItemProvider.php:387 Reply Unresolved

    This is also a great idea and could improve other places in the core, that do many calls to this method at once, as well... will look at it tomorrow.
  8. Christian Eßl uploaded patch set 3 CR +1 V +1 11/23/23, 12:37

  9. core-ci voted on patch set 3 V -1 11/23/23, 13:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49675

  10. Christian Eßl uploaded patch set 4 V -1 11/23/23, 13:22

  11. Christian Kuhn commented on patch set 4 11/23/23, 13:31

    Unresolved

    how and when will eviction happen when dependent data changes at runtime?
  12. core-ci voted on patch set 4 V -1 11/23/23, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49682

  13. Stefan Bürk commented on patch set 4 11/24/23, 15:33

    TcaGroupTest.php:40 Unresolved

    Method `set()` does not have an return value, so returning false as return value is technically wrong. Due to not having native return type `void` in the interface, this does not crash at the moment but will when added. Please remote the `willReturn()` here.
  14. Georg Ringer commented on patch set 5 V -1 05/28/24, 20:47

    Published edit on patch set 4.
  15. core-ci voted on patch set 5 V -1 05/28/24, 20:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58414

  16. Georg Ringer uploaded patch set 6 V -1 05/29/24, 04:52

  17. core-ci voted on patch set 6 V -1 05/29/24, 05:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58431

  18. Georg Ringer rebased onto patch set 7 V -1 07/12/24, 17:30

  19. core-ci voted on patch set 7 V -1 07/12/24, 17:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61502

  20. Georg Ringer uploaded patch set 8 V -1 07/12/24, 17:43

  21. core-ci voted on patch set 8 V -1 07/12/24, 17:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61503

  22. Benni Mack marked it work in progress 03/27/25, 17:36