81873[TASK] Show content as accordions in element information modal
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/Sass/component/_table.scss+9 −0
- Build/Sources/TypeScript/backend/element-information.tsnew+59 −0
- typo3/sysext/backend/Resources/Private/Templates/ContentElement/ElementInformation.html+193 −99
- typo3/sysext/backend/Resources/Public/Css/backend.css+4 −0
- typo3/sysext/backend/Resources/Public/JavaScript/element-information.jsnew+13 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+10 −1
- typo3/sysext/core/Resources/Private/Language/locallang_mod_web_list.xlf+1 −1
Review log 4066
Show 2141 earlier messages
-
Jasmina Ließmann uploaded patch set 1 11/22/23, 19:58
-
core-ci voted on patch set 1 V -1 11/22/23, 20:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49516
-
Jasmina Ließmann uploaded patch set 2
V -111/22/23, 21:05 -
core-ci voted on patch set 2 V -1 11/22/23, 21:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49553
-
Jasmina Ließmann uploaded patch set 3
V -111/23/23, 09:57 -
core-ci voted on patch set 3 V -1 11/23/23, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49622
-
Jasmina Ließmann uploaded patch set 4
V -111/23/23, 15:04 -
core-ci voted on patch set 4 V -1 11/23/23, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49708
-
Jasmina Ließmann uploaded patch set 5
V -111/23/23, 16:38 -
core-ci voted on patch set 5 V -1 11/23/23, 16:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49791
-
Jasmina Ließmann uploaded patch set 6
V -111/23/23, 16:49 -
core-ci voted on patch set 6 V -1 11/23/23, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49792
-
Jasmina Ließmann uploaded patch set 7
V -111/23/23, 16:59 -
core-ci voted on patch set 7 V -1 11/23/23, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49793
-
Jasmina Ließmann uploaded patch set 8
V -111/23/23, 17:41 -
Jasmina Ließmann uploaded patch set 9 11/23/23, 17:48
-
core-ci voted on patch set 8 V -1 11/23/23, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49798
-
core-ci voted on patch set 9 V -1 11/23/23, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49801
-
Jasmina Ließmann uploaded patch set 10
V -111/24/23, 10:49 -
core-ci voted on patch set 10 V -1 11/24/23, 10:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49879
-
Jasmina Ließmann uploaded patch set 11
V -111/24/23, 10:59 -
core-ci voted on patch set 11 V -1 11/24/23, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49881
-
Jasmina Ließmann uploaded patch set 12
V -111/24/23, 11:10 -
core-ci voted on patch set 12 V +1 11/24/23, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49885
-
Jasmina Ließmann uploaded patch set 13
V +111/24/23, 19:54 -
core-ci voted on patch set 13 V +1 11/24/23, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49903
-
Jasmina Ließmann uploaded patch set 14
V +111/26/23, 12:42 -
core-ci voted on patch set 14 V +1 11/26/23, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49949
-
Jasmina Ließmann uploaded patch set 15
V +103/18/24, 10:04 -
core-ci voted on patch set 15 V +1 03/18/24, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54650
-
Jasmina Ließmann uploaded patch set 16
V +103/18/24, 11:11 -
core-ci voted on patch set 16 V -1 03/18/24, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54653
-
Jasmina Ließmann uploaded patch set 17 03/18/24, 12:30
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
Jasmina Ließmann uploaded patch set 18
V -103/18/24, 12:31 -
Jasmina Ließmann uploaded patch set 19 03/18/24, 12:34
-
core-ci voted on patch set 17 V -1 03/18/24, 12:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54654
-
core-ci voted on patch set 18 V -1 03/18/24, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54655
-
core-ci voted on patch set 19 V +1 03/18/24, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54657
-
Jasmina Ließmann uploaded patch set 20
V +103/18/24, 12:57 -
core-ci voted on patch set 20 V +1 03/18/24, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54658
-
Jasmina Ließmann updated the commit message in patch set 21
V +103/18/24, 14:05
-
Jasmina Ließmann updated the commit message in patch set 22 03/18/24, 14:11
-
core-ci voted on patch set 21 V +1 03/18/24, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54660
-
Jasmina Ließmann updated the commit message in patch set 23 03/18/24, 14:16
-
core-ci voted on patch set 22 V -1 03/18/24, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54662
-
core-ci voted on patch set 23 V +1 03/18/24, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54663
-
Georg Ringer commented on patch set 23 03/19/24, 15:13
accordions limit the possibility to search by browser which I love very much. not giving a -1 but I am not sure if this is more a drawback - looking nice is not always the thing people need -
Garvin Hicking commented on patch set 23 03/19/24, 18:16
Reply
The way I tested it, the accordions remember state - so you could always leave them open, and it would not impact you? -
Oli Bartsch uploaded patch set 24
V +103/21/24, 10:38 -
core-ci voted on patch set 24 V +1 03/21/24, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54780
-
Jasmina Ließmann uploaded patch set 25
V +103/21/24, 17:24 -
Jasmina Ließmann commented on patch set 25 03/21/24, 17:28
Reply
As Garvin already said, the open/closed state of each accordion is saved. I've now changed it so that when the modal is first called, all three accordions are open by default. If necessary, the user can close them individually. -
core-ci voted on patch set 25 V +1 03/21/24, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54812
-
Garvin Hicking voted on patch set 25 CR +1 V +1 03/21/24, 18:02
-
Jörg Bösche voted on patch set 25 CR +1 03/25/24, 11:51
-
Stefan Bürk commented on patch set 25 V +1 04/10/24, 14:41
code looks also good from myside, leaving +1 code review out for now - should be reviewed by the CSS/JS experts for hidden corner stones I may oversee. -
Stefan Bürk voted on patch set 25 CR +1 04/10/24, 15:38
-
Jasmina Ließmann voted on patch set 25 CR +2 V +2 04/10/24, 16:28
-
Jasmina Ließmann voted on patch set 25 CR 0 V 0 04/10/24, 16:28
-
Jasmina Ließmann uploaded patch set 26
CR +1V +104/10/24, 16:36 -
core-ci voted on patch set 26 V +1 04/10/24, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55696
-
Jasmina Ließmann commented on patch set 26 04/10/24, 16:45
New patchset due to a merge conflict. Re-votes are welcome :) -
Garvin Hicking voted on patch set 26 CR +1 V +1 04/17/24, 11:43
-
Stefan Bürk voted on patch set 26 CR +1 V +1 04/17/24, 11:45
-
Jasmina Ließmann voted on patch set 26 CR +2 V +2 04/17/24, 11:46
-
Jasmina Ließmann merged patch set 27 04/17/24, 11:46