Review main Merged

81873[TASK] Show content as accordions in element information modal

Jasmina Ließmann CR +2 V +2 Hard +289 −101 updated 04/17/24, 11:46

Commit message

The element information modal displays both field information for the
current record and its references.
The more fields there are in a table and the more content the specific
record contains, the more the reference sections disappear from view.

The three sections are now displayed as accordions to enable the user
to decide for themselves which sections are relevant to them.
In addition, the display of non-existent records in the reference
sections has been adjusted and information about the paths/storage
locations has been removed, as these can already be viewed in the
record's editing mask.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 4066

Show 2141 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 11/22/23, 19:58

  2. core-ci voted on patch set 1 V -1 11/22/23, 20:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49516

  3. Jasmina Ließmann uploaded patch set 2 V -1 11/22/23, 21:05

  4. core-ci voted on patch set 2 V -1 11/22/23, 21:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49553

  5. Jasmina Ließmann uploaded patch set 3 V -1 11/23/23, 09:57

  6. core-ci voted on patch set 3 V -1 11/23/23, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49622

  7. Jasmina Ließmann uploaded patch set 4 V -1 11/23/23, 15:04

  8. core-ci voted on patch set 4 V -1 11/23/23, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49708

  9. Jasmina Ließmann uploaded patch set 5 V -1 11/23/23, 16:38

  10. core-ci voted on patch set 5 V -1 11/23/23, 16:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49791

  11. Jasmina Ließmann uploaded patch set 6 V -1 11/23/23, 16:49

  12. core-ci voted on patch set 6 V -1 11/23/23, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49792

  13. Jasmina Ließmann uploaded patch set 7 V -1 11/23/23, 16:59

  14. core-ci voted on patch set 7 V -1 11/23/23, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49793

  15. Jasmina Ließmann uploaded patch set 8 V -1 11/23/23, 17:41

  16. Jasmina Ließmann uploaded patch set 9 11/23/23, 17:48

  17. core-ci voted on patch set 8 V -1 11/23/23, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49798

  18. core-ci voted on patch set 9 V -1 11/23/23, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49801

  19. Jasmina Ließmann uploaded patch set 10 V -1 11/24/23, 10:49

  20. core-ci voted on patch set 10 V -1 11/24/23, 10:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49879

  21. Jasmina Ließmann uploaded patch set 11 V -1 11/24/23, 10:59

  22. core-ci voted on patch set 11 V -1 11/24/23, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49881

  23. Jasmina Ließmann uploaded patch set 12 V -1 11/24/23, 11:10

  24. core-ci voted on patch set 12 V +1 11/24/23, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49885

  25. Jasmina Ließmann uploaded patch set 13 V +1 11/24/23, 19:54

  26. core-ci voted on patch set 13 V +1 11/24/23, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49903

  27. Jasmina Ließmann uploaded patch set 14 V +1 11/26/23, 12:42

  28. core-ci voted on patch set 14 V +1 11/26/23, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49949

  29. Jasmina Ließmann uploaded patch set 15 V +1 03/18/24, 10:04

  30. core-ci voted on patch set 15 V +1 03/18/24, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54650

  31. Jasmina Ließmann uploaded patch set 16 V +1 03/18/24, 11:11

  32. core-ci voted on patch set 16 V -1 03/18/24, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54653

  33. Jasmina Ließmann uploaded patch set 17 03/18/24, 12:30

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  34. Jasmina Ließmann uploaded patch set 18 V -1 03/18/24, 12:31

  35. Jasmina Ließmann uploaded patch set 19 03/18/24, 12:34

  36. core-ci voted on patch set 17 V -1 03/18/24, 12:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54654

  37. core-ci voted on patch set 18 V -1 03/18/24, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54655

  38. core-ci voted on patch set 19 V +1 03/18/24, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54657

  39. Jasmina Ließmann uploaded patch set 20 V +1 03/18/24, 12:57

  40. core-ci voted on patch set 20 V +1 03/18/24, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54658

  41. Jasmina Ließmann updated the commit message in patch set 21 V +1 03/18/24, 14:05

  1. Jasmina Ließmann updated the commit message in patch set 22 03/18/24, 14:11

  2. core-ci voted on patch set 21 V +1 03/18/24, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54660

  3. Jasmina Ließmann updated the commit message in patch set 23 03/18/24, 14:16

  4. core-ci voted on patch set 22 V -1 03/18/24, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54662

  5. core-ci voted on patch set 23 V +1 03/18/24, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54663

  6. Georg Ringer commented on patch set 23 03/19/24, 15:13

    accordions limit the possibility to search by browser which I love very much. not giving a -1 but I am not sure if this is more a drawback - looking nice is not always the thing people need
  7. Garvin Hicking commented on patch set 23 03/19/24, 18:16

    Reply

    The way I tested it, the accordions remember state - so you could always leave them open, and it would not impact you?
  8. Oli Bartsch uploaded patch set 24 V +1 03/21/24, 10:38

  9. core-ci voted on patch set 24 V +1 03/21/24, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54780

  10. Jasmina Ließmann uploaded patch set 25 V +1 03/21/24, 17:24

  11. Jasmina Ließmann commented on patch set 25 03/21/24, 17:28

    Reply

    As Garvin already said, the open/closed state of each accordion is saved. I've now changed it so that when the modal is first called, all three accordions are open by default. If necessary, the user can close them individually.
  12. core-ci voted on patch set 25 V +1 03/21/24, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54812

  13. Garvin Hicking voted on patch set 25 CR +1 V +1 03/21/24, 18:02

  14. Jörg Bösche voted on patch set 25 CR +1 03/25/24, 11:51

  15. Stefan Bürk commented on patch set 25 V +1 04/10/24, 14:41

    code looks also good from myside, leaving +1 code review out for now - should be reviewed by the CSS/JS experts for hidden corner stones I may oversee.
  16. Stefan Bürk voted on patch set 25 CR +1 04/10/24, 15:38

  17. Jasmina Ließmann voted on patch set 25 CR +2 V +2 04/10/24, 16:28

  18. Jasmina Ließmann voted on patch set 25 CR 0 V 0 04/10/24, 16:28

  19. Jasmina Ließmann uploaded patch set 26 CR +1 V +1 04/10/24, 16:36

  20. core-ci voted on patch set 26 V +1 04/10/24, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55696

  21. Jasmina Ließmann commented on patch set 26 04/10/24, 16:45

    New patchset due to a merge conflict. Re-votes are welcome :)
  22. Garvin Hicking voted on patch set 26 CR +1 V +1 04/17/24, 11:43

  23. Stefan Bürk voted on patch set 26 CR +1 V +1 04/17/24, 11:45

  24. Jasmina Ließmann voted on patch set 26 CR +2 V +2 04/17/24, 11:46

  25. Jasmina Ließmann merged patch set 27 04/17/24, 11:46