Review 12.4 Merged

81876[BUGFIX] Suppress command output in functional tests

Stefan Bürk CR +2 V +2 Normal +46 −31 updated 11/22/23, 21:01

Commit message

In #102417 the cli tests were moved to functional
tests. This leads to (unwanted) additional on top of
the dot output in the functional tests.

This has been fixed by using proc_open to catch
the output of the progressbar and friends. Also
the args argument is fixed to allow for multiple
arguments to be used in the data provider.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Stefan Bürk uploaded patch set 1 11/22/23, 20:24

  2. core-ci voted on patch set 1 V -1 11/22/23, 20:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49522

  3. Stefan Bürk commented on patch set 2 V -1 11/22/23, 20:42

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 11/22/23, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49546

  5. Stefan Bürk voted on patch set 2 CR +2 V +2 11/22/23, 21:01

  6. Stefan Bürk merged patch set 3 11/22/23, 21:01