81879[TASK] Add aria-label to datepicker button
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Christian Rath-Ulrich +1
- Willi Wehmeier +1
-
Verified V +2 Done
- Christian Kuhn +2
- Christian Rath-Ulrich +1
- Willi Wehmeier +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2029
Show 24 earlier messages
-
Christian Rath-Ulrich uploaded patch set 1 11/22/23, 20:58
-
core-ci voted on patch set 1 V -1 11/22/23, 21:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49552
-
Christian Rath-Ulrich uploaded patch set 2
V -111/22/23, 22:08 -
core-ci voted on patch set 2 V +1 11/22/23, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49566
-
Simon Schaufelberger updated the commit message in patch set 3
V +111/22/23, 23:53 -
core-ci voted on patch set 3 V +1 11/22/23, 23:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49570
-
Christian Rath-Ulrich uploaded patch set 4
V +111/23/23, 08:22 -
Christian Rath-Ulrich uploaded patch set 5 11/23/23, 08:25
-
core-ci voted on patch set 4 V +1 11/23/23, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49593
-
core-ci voted on patch set 5 V +1 11/23/23, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49594
-
Christian Rath-Ulrich uploaded patch set 6
V +111/29/23, 09:06 -
core-ci voted on patch set 6 V +1 11/29/23, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50096
-
Christian Rath-Ulrich uploaded patch set 7
V +111/29/23, 09:14 -
core-ci voted on patch set 7 V +1 11/29/23, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50098
-
Patrick Schriner commented on patch set 7 CR -1 V -1 12/04/23, 10:38
This does more than intentionedDatetimeElement.php:207labels.datepicker.arialabel is not usedBackendUtility.php:1235this has a lot of other consequences and doesn't just affect the datepicker -
Christian Rath-Ulrich uploaded patch set 8
CR -1V +112/06/23, 10:36 -
Christian Rath-Ulrich commented on patch set 7 12/06/23, 10:38
Reply
yes i pushed some that belonged to another fix. but its fixed nowDatetimeElement.php:207ReplyfixedBackendUtility.php:1235Replythis just fixes a mistake i made before i set the file back to the state of main -
core-ci voted on patch set 8 V +1 12/06/23, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50411
-
Benjamin Kott commented on patch set 8 CR -1 03/01/24, 07:04
From my understanding, title and aria-label are both added due to the differences in screen readers. The labels are containing the same contents, if feels wrong to add them both. Can you elaborate on how this was tested and what screenreaders are affected by only having the title attribute and needing the aria attribute? -
Michael Telgkamp commented on patch set 8 CR -1 03/01/24, 07:30
From my experience the title attribute most of the time is added to have some kind of tooltip for the button. Am I right with this assumption? In my opinion the button calendar icon is well known as an icon for date pickers (similar to the loupe for search), thus I think a tooltip is not required here. The main downside of having a title attribute as well as an aria-label is, that most browsers use the title attribute as description, if a label is set. In this case the same text is read out twice to the user which is unwanted behaviour. -
Christian Rath-Ulrich commented on patch set 8 03/01/24, 08:28
Reply
So, is the suggestion to get rid of the title attribute? -
Michael Telgkamp commented on patch set 8 03/01/24, 09:54
Reply
In my opinion I do not see a benefit of the title attribute, on the other side it causes screen readers to read out the text twice. So yes, I would remove the title attribute. -
Patrick Schriner uploaded patch set 9
CR -1V +103/04/24, 08:12 -
core-ci voted on patch set 9 V +1 03/04/24, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53810
-
Patrick Schriner commented on patch set 9 03/04/24, 08:27
Reply
Done -
Christian Rath-Ulrich voted on patch set 9 CR +1 V +1 03/04/24, 22:18
-
Willi Wehmeier voted on patch set 9 CR +1 V +1 03/06/24, 09:41
-
Christian Kuhn voted on patch set 9 CR +2 V +2 03/06/24, 21:19
-
Christian Kuhn merged patch set 10 03/06/24, 21:19