81887[!!!][TASK] Remove tx_extbase_type from fe_groups
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Torben Hansen +1
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Torben Hansen +1
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102924-SingleTableInheritanceFromFeGroupsRemoved.rstnew+59 −0
- typo3/sysext/extbase/Configuration/TCA/Overrides/fe_groups.phpdeleted+0 −34
- typo3/sysext/extbase/Resources/Private/Language/locallang_db.xlf+0 −9
- typo3/sysext/extbase/ext_tables.sql2+0 −5
- typo3/sysext/frontend/Tests/Functional/Tca/FrontendGroupsVisibleFieldsTest.php+0 −1
Review log 1621
-
Josef Glatz uploaded patch set 1 11/23/23, 09:49
-
core-ci voted on patch set 1 V +1 11/23/23, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49619
-
Josef Glatz commented on patch set 1 11/23/23, 09:56
This change is ready for review.Here's my patch. Please take a look into the commit message! I've added some todo's and questions already in the commit message! I'm also available for a spontaneous huddle if it's easier to discussext_tables.sql:14Should we keep the file until e.g. TYPO3 14/15? background: smoother upgrade path: - project get's upgraded - integrator/developer can implement all necessary after reading the important/breaking rStÄs of this patch How did we handle such a situation before? Because we can also discard it. If the upgrader do a DB COMPARE the mentioned columns are marked for deletion. Also a good path for me -
Josef Glatz updated the commit message in patch set 2
V +111/23/23, 10:01 -
core-ci voted on patch set 2 V +1 11/23/23, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49625
-
Markus Klein commented on patch set 2 CR -1 11/23/23, 10:16
I would keep the field at least for fe_users. It's a common TCA-type field, where extensions can build upon. I fear, if this is removed from Core, extensions may come up with different type-field names and will cause collisions. ("Strong default from Core" is what I would expect here.) -
Josef Glatz commented on patch set 2 11/23/23, 10:29
Reply
@markus.klein@typo3.org This is also valid option for me. Things I would adopt in the patch (or another patch) if we keep fe_users.tx_extbase_type: - move the TCA of fe_users.tx_extbase_type into ext:frontend - move the XLF strings into ext:frontend - move the type field into first register of backend form (like it is in ext:news records) - add meaningful default type name "Default" - remove the recordType value `Tx_Extbase_Domain_Model_FrontendUser` What I don't know is why we should drop fe_groups.tx_extbase_type then... Keeping them also to have also here a fixed type column for this table? -
Torben Hansen commented on patch set 2 11/23/23, 14:50
Reply
Many extension in TER use `tx_extbase_type` as field for Single Table Inheritance. In TER even some extension extend `fe_users` and `fe_groups` relying on the `tx_extbase_type` field. So lets keep the field for both tables and move it to ext:frontend. The `Tx_Extbase_Domain_Model_FrontendUser` as well as the `Tx_Extbase_Domain_Model_FrontendUser` field should be removed and the default states get a meaningful value. Additionally, the whole topic around what tx_extbase_type, Single Table Inheritance and its configured (`Extbase/Persistence/Classes.php` and a field - usually `tx_extbase_type`, which defines the `recordType`) must be documented properly. -
Benni Mack commented on patch set 2 01/23/24, 19:31
let's remove it from the groups please -
Benni Mack uploaded patch set 3
CR -1V +101/24/24, 10:33 -
core-ci voted on patch set 3 V +1 01/24/24, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52067
-
Benni Mack uploaded patch set 4
V +101/25/24, 10:32 -
core-ci voted on patch set 4 V -1 01/25/24, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52150
-
Benni Mack commented on patch set 4 01/25/24, 13:15
ext_tables.sql:14ReplyDone -
Benni Mack rebased onto patch set 5
V -101/25/24, 13:15 -
core-ci voted on patch set 5 V +1 01/25/24, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52179
-
Christian Kuhn voted on patch set 5 CR +1 V +1 01/25/24, 14:31
-
Stefan Bürk voted on patch set 5 CR +1 V +1 01/25/24, 14:36
-
Torben Hansen voted on patch set 5 CR +1 V +1 01/25/24, 14:37
-
Benni Mack voted on patch set 5 CR +2 V +2 01/25/24, 15:07
-
Benni Mack merged patch set 6 01/25/24, 15:07