Review main Merged

81902Revert "[TASK] Respect not-nullable strings in `TableBuilder`"

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 11/24/23, 10:36

Commit message

This reverts commit 3bac9e44783d6bdb901617e58226e9aaacaf1b86.

#102495 ensured that the `ext_tables.sql` scanning using
the own sql parser set column comments to an empty string
instead of using the default of null.

This has been done as a preparation for the next Doctrine
DBAL major version upgrade.

Due to the fact that the doctrine `Column` does not contain
the "string" enforcement this now means that empty comments
are detected as changes for PostgreSQL.

It does not make sense to extend and replace all the classes
of doctrine to reflect the upcoming changes, therefore this
change is reverted. 

The original intention needs to be included with the major
Doctrine DBAL upgrade.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Stefan Bürk uploaded patch set 1 11/24/23, 09:19

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 11/24/23, 09:40

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 11/24/23, 09:42

  4. Andreas Nedbal voted on patch set 1 CR +1 V +1 11/24/23, 09:43

  5. core-ci voted on patch set 1 V +1 11/24/23, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49853

  6. Stefan Bürk voted on patch set 1 CR +2 V +2 11/24/23, 10:36

  7. Stefan Bürk merged patch set 2 11/24/23, 10:36