81917[TASK] Cache ordered providers in FormEngine
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 16
- typo3/sysext/backend/Classes/Form/FormDataGroup/FlexFormSegment.php+10 −14
- typo3/sysext/backend/Classes/Form/FormDataGroup/OnTheFly.php+3 −14
- typo3/sysext/backend/Classes/Form/FormDataGroup/OrderedProviderList.php2+25 −23
- typo3/sysext/backend/Classes/Form/FormDataGroup/SiteConfigurationDataGroup.php+10 −13
- typo3/sysext/backend/Classes/Form/FormDataGroup/TcaDatabaseRecord.php+10 −14
- typo3/sysext/backend/Classes/Form/FormDataGroup/TcaInputPlaceholderRecord.php+9 −13
- typo3/sysext/backend/Classes/Form/FormDataGroup/TcaSelectTreeAjaxFieldData.php+10 −14
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaFlexProcessTest.phprenamed+5 −5
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaInputPlaceholdersTest.phprenamed+15 −29
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/FlexFormSegmentTest.php+16 −30
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/OrderedProviderListTest.php+6 −30
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/SiteConfigurationDataGroupTest.php+16 −30
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaDatabaseRecordTest.php+16 −30
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaInputPlaceholderRecordTest.php+16 −30
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaSelectTreeAjaxFieldDataTest.php+16 −30
- typo3/sysext/core/Classes/Service/DependencyOrderingService.php+1 −1
Review log 1724
-
Christian Eßl uploaded patch set 1 11/23/23, 12:16
-
core-ci voted on patch set 1 V -1 11/23/23, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49664
-
Christian Eßl uploaded patch set 2
V -111/23/23, 13:34 -
Christian Kuhn commented on patch set 1 11/23/23, 13:36
-
core-ci voted on patch set 2 V +1 11/23/23, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49688
-
Christian Kuhn uploaded patch set 3
V +112/17/24, 16:54 -
Christian Kuhn commented on patch set 3 12/17/24, 16:58
hey. i think this patch is worth to get done: the calcutlated prodiver list is a straight side-free function from the input list, which is compile-time configuration. i think it does not harm to add a runtime-cache layer here. the current construct however suffers from 'setProviderList()' which makes everything stateful. i think we should have a first patch to deal with the performance issue, and then post-patches to get rid of 'setProviderList()' by changing compile() interface, *or* having a factory for the entire thing. -
Christian Kuhn commented on patch set 3 12/17/24, 17:00
Reply
for now, i pushed a rather straight change to use DI and to merge the cache identifier calculation into compile (which is quick), to suppress dependencyOrderingService calls on each call, but the tests will fail at the moment, and this needs a bit more detail changes to get done. -
core-ci voted on patch set 3 V -1 12/17/24, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71298
-
Christian Kuhn commented on patch set 3 01/07/25, 15:51
i measured this a bit with blackfire: setup is an image CE with 10 "opened" images. the change gives a measurable performance improvements - about 5% in this setup. i think we should finish the change. -
Christian Kuhn uploaded patch set 4
V -101/07/25, 16:47 -
Christian Kuhn commented on patch set 4 01/07/25, 16:48
OrderedProviderList.php:104ReplyDone -
Christian Kuhn commented on patch set 4 01/07/25, 16:53
Reply
Done -
core-ci voted on patch set 4 V -1 01/07/25, 16:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72053
-
Christian Kuhn uploaded patch set 5
V -101/07/25, 16:56 -
core-ci voted on patch set 5 V +1 01/07/25, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72054
-
Christian Kuhn updated the commit message in patch set 6
V +101/07/25, 17:17 -
core-ci voted on patch set 6 V +1 01/07/25, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72055
-
Christian Kuhn updated the commit message in patch set 7
V +101/07/25, 17:25 -
Christian Kuhn voted on patch set 7 CR +1 V +1 01/07/25, 17:25
-
core-ci voted on patch set 7 V +1 01/07/25, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72056
-
Benni Mack voted on patch set 7 CR +1 V +1 01/08/25, 06:46
-
Oli Bartsch voted on patch set 7 CR +2 V +2 01/08/25, 07:37
-
Oli Bartsch merged patch set 8 01/08/25, 07:37
OrderedProviderList.php:104