81918[BUGFIX] Prevent side effects from ViewHelpers
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Simon Praetorius +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ValidationResultsViewHelper.php+9 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+5 −3
- typo3/sysext/fluid/Classes/ViewHelpers/FlashMessagesViewHelper.php+8 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/ValidationResultsViewHelperTest.phpnew+72 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/TypolinkViewHelperTest.php+7 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FlashMessagesViewHelperTest.php+30 −0
- typo3/sysext/form/Classes/ViewHelpers/RenderFormValueViewHelper.php+5 −3
- typo3/sysext/form/Tests/Functional/ViewHelpers/Form/UploadedResourceViewHelperTest.phprenamed+1 −1
- typo3/sysext/form/Tests/Functional/ViewHelpers/RenderFormValueViewHelperTest.phpnew+139 −0
Review log 1321
-
Simon Praetorius uploaded patch set 1 11/23/23, 12:18
-
core-ci voted on patch set 1 V -1 11/23/23, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49668
-
Simon Praetorius uploaded patch set 2
V -111/23/23, 18:00 -
core-ci voted on patch set 2 V -1 11/23/23, 18:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49806
-
Simon Praetorius rebased onto patch set 3
V -111/24/23, 10:40 -
Simon Praetorius uploaded patch set 4 11/24/23, 10:40
-
core-ci voted on patch set 4 V -1 11/24/23, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49878
-
core-ci voted on patch set 3 V -1 11/24/23, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49877
-
Simon Praetorius uploaded patch set 5
V -111/28/23, 10:13 -
Simon Praetorius marked it ready for review 11/28/23, 10:13
-
Simon Praetorius updated the commit message in patch set 6 11/28/23, 10:14
-
core-ci voted on patch set 5 V -1 11/28/23, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50047
-
core-ci voted on patch set 6 V -1 11/28/23, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50048
-
Simon Praetorius uploaded patch set 7
V -111/28/23, 10:20 -
Simon Praetorius updated the commit message in patch set 8 11/28/23, 10:22
-
core-ci voted on patch set 7 V +1 11/28/23, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50049
-
core-ci voted on patch set 8 V +1 11/28/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50050
-
Christian Kuhn voted on patch set 8 CR +1 V +1 11/29/23, 19:30
-
Stefan Bürk voted on patch set 8 CR +1 V +1 11/29/23, 19:31
-
Simon Praetorius voted on patch set 8 CR +2 V +2 11/29/23, 19:43
-
Simon Praetorius merged patch set 9 11/29/23, 19:43