Review main Merged

81918[BUGFIX] Prevent side effects from ViewHelpers

Simon Praetorius CR +2 V +2 Hard +276 −13 updated 11/29/23, 19:43

Commit message

Fluid now provides a ScopedVariableProvider to make sure that
ViewHelpers that provide variables to child nodes don't change
global variable state. With this patch, the new
ScopedVariableProvider from Fluid Standalone is used in Core
ViewHelpers as well.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1321

  1. Simon Praetorius uploaded patch set 1 11/23/23, 12:18

  2. core-ci voted on patch set 1 V -1 11/23/23, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49668

  3. Simon Praetorius uploaded patch set 2 V -1 11/23/23, 18:00

  4. core-ci voted on patch set 2 V -1 11/23/23, 18:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49806

  5. Simon Praetorius rebased onto patch set 3 V -1 11/24/23, 10:40

  6. Simon Praetorius uploaded patch set 4 11/24/23, 10:40

  7. core-ci voted on patch set 4 V -1 11/24/23, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49878

  8. core-ci voted on patch set 3 V -1 11/24/23, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49877

  9. Simon Praetorius uploaded patch set 5 V -1 11/28/23, 10:13

  10. Simon Praetorius marked it ready for review 11/28/23, 10:13

  11. Simon Praetorius updated the commit message in patch set 6 11/28/23, 10:14

  12. core-ci voted on patch set 5 V -1 11/28/23, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50047

  13. core-ci voted on patch set 6 V -1 11/28/23, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50048

  14. Simon Praetorius uploaded patch set 7 V -1 11/28/23, 10:20

  15. Simon Praetorius updated the commit message in patch set 8 11/28/23, 10:22

  16. core-ci voted on patch set 7 V +1 11/28/23, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50049

  17. core-ci voted on patch set 8 V +1 11/28/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50050

  18. Christian Kuhn voted on patch set 8 CR +1 V +1 11/29/23, 19:30

  19. Stefan Bürk voted on patch set 8 CR +1 V +1 11/29/23, 19:31

  20. Simon Praetorius voted on patch set 8 CR +2 V +2 11/29/23, 19:43

  21. Simon Praetorius merged patch set 9 11/29/23, 19:43